[PATCH 07/11] sunxi: pmic_bus: Fix Kconfig dependencies

Jaehoon Chung jh80.chung at samsung.com
Fri Sep 3 01:17:43 CEST 2021


On 8/22/21 8:05 AM, Samuel Holland wrote:
> AXP_PMIC_BUS enables communication with a specific AXP PMIC at a
> PMIC-dependent I2C/P2WI/RSB bus address. It is automatically selected
> as a dependency of the PMIC driver. It should not be selectable by the
> user when no PMIC is chosen.
> 
> AXP_GPIO uses the pmic_bus functions, and also depends on a specific
> PMIC header to pick up register definitions.
> 
> Both of these changes have no impact on any existing configs, since
> the code does not compile if the dependencies are not met.
> 
> Signed-off-by: Samuel Holland <samuel at sholland.org>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
> 
>  arch/arm/mach-sunxi/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 28332008501..12235fabc06 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -95,7 +95,7 @@ config SUN6I_PRCM
>  	  in A31 SoC.
>  
>  config AXP_PMIC_BUS
> -	bool "Sunxi AXP PMIC bus access helpers"
> +	bool
>  	help
>  	  Select this PMIC bus access helpers for Sunxi platform PRCM or other
>  	  AXP family PMIC devices.
> @@ -796,6 +796,7 @@ endif
>  
>  config AXP_GPIO
>  	bool "Enable support for gpio-s on axp PMICs"
> +	depends on AXP_PMIC_BUS
>  	default n
>  	---help---
>  	Say Y here to enable support for the gpio pins of the axp PMIC ICs.
> 



More information about the U-Boot mailing list