[PATCH] board: rpi: always set fdt_addr if provided by firmware

Matthias Brugger mbrugger at suse.com
Mon Sep 27 14:01:35 CEST 2021


Hi Oleksandr,

Thanks for your patch.

There was the very same patch posted already, please follow-up in that thread 
for any comments from your side:
https://patchwork.ozlabs.org/project/uboot/patch/20210512123945.25649-1-m.salvini@koansoftware.com/

Regards,
Matthias

On 25/09/2021 12:22, Oleksandr Suvorov wrote:
> From: Ricardo Salveti <ricardo at foundries.io>
> 
> Otherwise if the env gets saved with an incorrect or different
> fdt_addr (by moving sdcard between different rpi versions), it won't
> be able to boot with the correct address.
> 
> This allows fdt_addr to always be in sync with what gets set by the
> firmware.
> 
> Signed-off-by: Ricardo Salveti <ricardo at foundries.io>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov at foundries.io>
> ---
> 
>   board/raspberrypi/rpi/rpi.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
> index 372b26b6f2..e12f8c0c31 100644
> --- a/board/raspberrypi/rpi/rpi.c
> +++ b/board/raspberrypi/rpi/rpi.c
> @@ -318,9 +318,6 @@ static void set_fdtfile(void)
>    */
>   static void set_fdt_addr(void)
>   {
> -	if (env_get("fdt_addr"))
> -		return;
> -
>   	if (fdt_magic(fw_dtb_pointer) != FDT_MAGIC)
>   		return;
>   
> 



More information about the U-Boot mailing list