[PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation

Tom Rini trini at konsulko.com
Mon Dec 5 23:25:39 CET 2022


On Mon, Dec 05, 2022 at 09:35:41PM +0000, Peter Robinson wrote:
> On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek <msuchanek at suse.de> wrote:
> >
> > The i2c locks up when initialized before relocation, and it stays broken
> > in Linux as well breaking the ability to boot Linux.
> >
> > The i2c bus and pmic was not actually used in pre-reloc before
> > commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
> >
> > The cause is not known.
> >
> > This is board-specific, other boards that do not add the option to
> > include the i2c bus in pre-reloc DT are not affected.
> >
> > Signed-off-by: Michal Suchanek <msuchanek at suse.de>
> 
> Reviewed-by: Peter Robinson <pbrobinson at gmail.com>
> Tested-by: Peter Robinson <pbrobinson at gmail.com>
> 
> Thanks for checking this out, I had noticed a regression and had got
> as far as bisecting it but not getting to a fix.
> 
> Tom: can we get this pulled into 2023.01 please?

Probably should be, yes.  Kever, are there any other rockchip must-fixes
for v2023.01? I can take this directly if you don't have others and/or
don't want to make up a PR, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20221205/e572488e/attachment.sig>


More information about the U-Boot mailing list