[PATCH v3] arm: dts: rockchip: rk3399: usb: ehci: Fix EHCI probe in rk3399 to access peripherals by USB 2.

Marek Vasut marex at denx.de
Thu Dec 8 21:12:08 CET 2022


On 12/8/22 17:53, Xavier Drudis Ferran wrote:

[...]

> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -7,7 +7,7 @@
>    */
>   
>   #include <common.h>
> -#include <clk.h>
> +#include <clk-uclass.h>
>   #include <dm.h>
>   #include <asm/global_data.h>
>   #include <dm/device_compat.h>
> @@ -168,6 +168,9 @@ static struct phy_ops rockchip_usb2phy_ops = {
>   	.of_xlate = rockchip_usb2phy_of_xlate,
>   };
>   
> +static struct clk_ops rockchip_usb2phy_clk_ops = {
> +};

Is this empty structure needed ? Why ?

Either it shouldn't be here, or it should implement some callbacks, like 
clock enable/disable ?

Otherwise looks much better, thanks !


More information about the U-Boot mailing list