[PATCH] rockchip: Only call binman when TPL available

Simon Glass sjg at chromium.org
Mon Dec 19 20:20:42 CET 2022


Hi Kever,

On Sun, 18 Dec 2022 at 05:50, Kever Yang <kever.yang at rock-chips.com> wrote:
>
> Rockchip platform use TPL to do the DRAM initialize for all the SoCs,
> if TPL is not available, means no available DRAM init program, and the
> u-boot-rockchip.bin is not functionable.
>
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> ---
>
>  arch/arm/dts/rockchip-u-boot.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Can you please look at the series to convert things to binman? I found
another problem with it so can send v8, but I'd really like some
reviews on that.

For this patch, can you explain what the problem is right now?
>
> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi
> index 584f21eb5bf..e2b0f389711 100644
> --- a/arch/arm/dts/rockchip-u-boot.dtsi
> +++ b/arch/arm/dts/rockchip-u-boot.dtsi
> @@ -11,7 +11,7 @@
>         };
>  };
>
> -#ifdef CONFIG_SPL
> +#ifdef CONFIG_TPL_BUILD
>  &binman {
>         simple-bin {
>                 filename = "u-boot-rockchip.bin";
> --
> 2.25.1
>

Regards,
Simon


More information about the U-Boot mailing list