[PATCH 1/2] pmic: pca9450: add DM_I2C dependencies in Kconfig

Jaehoon Chung jh80.chung at samsung.com
Tue May 17 01:44:10 CEST 2022


On 5/3/22 17:58, Rasmus Villemoes wrote:
> The pca9450 driver uses dm_i2c_{read,write}, which
> are (unsurprisingly) only available with DM_I2C. Make sure one can't
> create an unbuildable .config by adding proper dependencies.
> 
> While here, append "in SPL" to the prompt for the SPL_ variant so it
> doesn't read the same as the one for the non-SPL_ variant.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/power/pmic/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
> index 953c92e212..6c534aead7 100644
> --- a/drivers/power/pmic/Kconfig
> +++ b/drivers/power/pmic/Kconfig
> @@ -158,13 +158,15 @@ config SPL_DM_PMIC_MP5416
>  
>  config DM_PMIC_PCA9450
>  	bool "Enable Driver Model for PMIC PCA9450"
> +	depends on DM_I2C
>  	help
>  	  This config enables implementation of driver-model pmic uclass features
>  	  for PMIC PCA9450. The driver implements read/write operations.
>  
>  config SPL_DM_PMIC_PCA9450
> -	bool "Enable Driver Model for PMIC PCA9450"
> +	bool "Enable Driver Model for PMIC PCA9450 in SPL"
>  	depends on SPL_DM_PMIC
> +	depends on SPL_DM_I2C
>  	help
>  	  This config enables implementation of driver-model pmic uclass features
>  	  for PMIC PCA9450 in SPL. The driver implements read/write operations.



More information about the U-Boot mailing list