[PATCH 1/1] cmd: convert fallthrough comment.

Tom Rini trini at konsulko.com
Fri Apr 7 16:50:11 CEST 2023


On Sat, Apr 01, 2023 at 09:14:11AM +0200, Heinrich Schuchardt wrote:

> gcc does not understand /* FALL TROUGH */ and emits a warning:
> 
>     cmd/date.c: In function ‘do_date’:
>     cmd/date.c:62:20: warning:
>     this statement may fall through [-Wimplicit-fallthrough=]
>        62 |                 if (strcmp(argv[1],"reset") == 0) {
>           |                    ^
>     cmd/date.c:102:9: note: here
>       102 |         case 1:                 /* get date & time */
>           |         ^~~~
> 
> Use the fallthrough macro instead.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230407/2f18c371/attachment.sig>


More information about the U-Boot mailing list