[PATCH v2 3/9] arrm: add ACPI fields to global data

Simon Glass sjg at chromium.org
Mon Dec 18 16:01:33 CET 2023


Hi Heinrich,

On Sat, 16 Dec 2023 at 12:23, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> On 12/16/23 19:46, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Fri, 15 Dec 2023 at 06:32, Heinrich Schuchardt
> > <heinrich.schuchardt at canonical.com> wrote:
> >>
> >> Add fields for the location of ACPI tables to the global data.
> >>
> >> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> >> ---
> >> v2:
> >>          new patch
> >> ---
> >>   arch/arm/include/asm/global_data.h | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >
> > These need to be #ifdefed as they affect global_data size,
> > particularly in SPL. In fact, we have a problem there.
>
> Why would it be problematic to have more unused fields in global data?

It uses memory, i.e. SRAM, which is not that large.

Regards,
Simon


More information about the U-Boot mailing list