[PATCH u-boot 2/2] tools: default_image: Accept images with padding

Simon Glass sjg at chromium.org
Mon Feb 6 23:00:51 CET 2023


Hi Tom,

On Mon, 6 Feb 2023 at 12:43, Tom Rini <trini at konsulko.com> wrote:
>
> On Sun, Jan 29, 2023 at 05:44:11PM +0100, Pali Rohár wrote:
>
> > If image file is stored on flash partition then it contains padding, which
> > is not part of the image itself. Image data size is stored in the image
> > header. So use image size from the header instead of expecting that total
> > image file size is size of the header plus size of the image data. This
> > allows dumpimage to parse image files with padding (e.g. dumped from flash
> > partition).
> >
> > Signed-off-by: Pali Rohár <pali at kernel.org>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> This breaks imx6q_bosch_acc imx6dl_mamoj as:
> ./tools/mkimage: Failed to verify header of u-boot-ivt.img
>
> now happens.

I know these failures are a pain, but it is great to see the testing
having such a big impact!

- Simon


More information about the U-Boot mailing list