[PATCH v2] usb: dwc3: Use the devm_gpiod_get_optional() API for reset gpio

Marek Vasut marex at denx.de
Wed Feb 22 16:33:51 CET 2023


On 2/22/23 08:01, Michal Simek wrote:
> 
> 
> On 2/22/23 02:06, Marek Vasut wrote:
>> On 1/13/23 06:12, Venkatesh Yadav Abbarapu wrote:
>>> As the "reset-gpios" property is optional, don't return the
>>> error and just skip the gpio reset sequence.
>>>
>>> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
>>> ---
>>> Changes in v2:
>>> - Replaced the gpio_request_by_name() the API with
>>> devm_gpiod_get_optional().
>>
>> The PX30 seems to fail to build:
>>
>> https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/580968
> 
> Doesn't look usb related.
> 
> +Please report this bug.
> +make[4]: *** [scripts/Makefile.build:257: spl/drivers/mmc/mmc.o] Error 1
> +make[3]: *** [scripts/Makefile.build:397: spl/drivers/mmc] Error 2
> +make[2]: *** [scripts/Makefile.spl:533: spl/drivers] Error 2
> 
> Can you please double check it?

u-boot/master without this patch built fine, usb/next just built fine 
too. I did retrigger the failing build to see if this is transient 
failure, but it would be good if someone at xilinx could build-test the 
px30 too .


More information about the U-Boot mailing list