[PATCH v4 27/45] pci: Adjust video BIOS debugging to be SPL-friendly

[Bin Meng]

Hi Simon,

On Mon, Jun 19, 2023 at 8:01 PM Simon Glass <sjg at chromium.org> wrote:
>
> A hex value is expected for the VGA mode. Drop the 0x prefix, which is
> not supported in SPL.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> (no changes since v1)
>
>  drivers/pci/pci_rom.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci_rom.c b/drivers/pci/pci_rom.c
> index ecb6da64c5c9..62cfe60c0fb2 100644
> --- a/drivers/pci/pci_rom.c
> +++ b/drivers/pci/pci_rom.c
> @@ -319,7 +319,7 @@ int dm_pci_run_vga_bios(struct udevice *dev, int (*int15_handler)(void),
>                 defined(CONFIG_FRAMEBUFFER_VESA_MODE)
>         vesa_mode = CONFIG_FRAMEBUFFER_VESA_MODE;
>  #endif
> -       debug("Selected vesa mode %#x\n", vesa_mode);
> +       debug("Selected vesa mode %x\n", vesa_mode);

Shouldn't we fix the SPL printf to ignore the '#' character?

Or we can simple remove # and add 0x explicitly?

>
>         if (exec_method & PCI_ROM_USE_NATIVE) {
>  #ifdef CONFIG_X86
> @@ -370,7 +370,7 @@ int dm_pci_run_vga_bios(struct udevice *dev, int (*int15_handler)(void),
>                 log_debug("done\n");
>  #endif
>         }
> -       debug("Final vesa mode %#x\n", mode_info.video_mode);
> +       debug("Final vesa mode %x\n", mode_info.video_mode);
>         ret = 0;
>
>  err:
> --

Regards,
Bin