[RFC 2/2] rockchip: rk3588: Add SoC specific RAM bank logic

Jonas Karlman jonas at kwiboo.se
Sat Mar 30 11:53:38 CET 2024


Hi Chris,

On 2024-03-30 06:05, Chris Morgan wrote:
> From: Chris Morgan <macromorgan at hotmail.com>
> 
> Add SoC specific RAM bank logic for the rk3588 boards. This logic
> works by reading the ATAGS created by the ROCKCHIP_TPL stage and
> applies fixups on those to ensure we aren't stepping on any
> reserved memory addresses.
> 
> The existing logic requires us to define memory holes to allow
> devices with 16GB or more RAM to function properly, as well as
> blocking up to 256MB of otherwise accessible RAM.

Looks good at first glance, will runtime test later.

Please move this out from being RK3588 specific, my prior request to
depend on !IS_ENABLED(CONFIG_ROCKCHIP_EXTERNAL_TPL) was so that this
also gets used on RK356x. On 4 GiB RAM RK356x boards the same 256 MiB
could be reclaimed with this.

For final patch submission please also remove all duplicated RK3588
board implementations of ft_board_setup() that adds reserved memory
nodes to DT, they are no longer needed after this.

Regards,
Jonas

> 
> Signed-off-by: Chris Morgan <macromorgan at hotmail.com>
> ---
>  arch/arm/mach-rockchip/rk3588/rk3588.c | 93 ++++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)
> 



More information about the U-Boot mailing list