<html>
<head>
<title></title>
</head>
<body>
Hi,
<br>
<br>
In cpu/ppc4xx/sdram.c, in sdram_init(), the following seems to be wrong.
<br>
<br>
/*
<br>
* Test if 128 MByte are equipped (mirror test)
<br>
*/
<br>
*(volatile ulong *)ADDR_ZERO = MAGIC0;
<br>
*(volatile ulong *)ADDR_08MB = MAGIC1;
<br>
*(volatile ulong *)ADDR_16MB = MAGIC2;
<br>
*(volatile ulong *)ADDR_32MB = MAGIC3;
<br>
*(volatile ulong *)ADDR_64MB = MAGIC4;
<br>
<br>
if ((*(volatile ulong *)ADDR_ZERO == MAGIC0) &&
<br>
(*(volatile ulong *)ADDR_08MB == MAGIC1) &&
<br>
(*(volatile ulong *)ADDR_16MB == MAGIC2) &&
<br>
(*(volatile ulong *)ADDR_32MB == MAGIC3)) {
<br>
/*
<br>
* OK, 128MB detected -> all done
<br>
*/
<br>
return;
<br>
}
<br>
<br>
I think the following conditional expression must be inserted at if statement:
<br>
(*(volatile ulong *)ADDR_64MB == MAGIC4)
<br>
<br>
The above case is also applied to 64MB and 32MB detection.
<br>
<br>
Thanks.
<br>
SYLee.
<br>
<!-- Empal Slogan Start -->
<hr noshade size=1 width=590 align=left>
<font style="font-size:9pt">Get your own 200MB free email at <a href="http://mail.empas.com" target="new_win1">http://www.empal.com</a><br>
<!-- Empal Slogan End -->
</body>
</html>