<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.8.1">
</HEAD>
<BODY>
Nishanth,<BR>
<BR>
Thanks for the feedback. I agree completely with what you're saying. Under no circumstances do we want to wreck existing implementations. I'll go ahead and play with this a bit... At the very least we can work switching of the ignore list into the set_bus command.<BR>
<BR>
regards,<BR>
Ben<BR>
<BR>
On Tue, 2006-05-16 at 12:15 -0500, Menon, Nishanth wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
<FONT COLOR="#000000">Hi Ben,</FONT>
<FONT COLOR="#000000">> One sticky part is, how do we deal with the 'CFG_I2C_NOPROBE' stuff?</FONT>
<FONT COLOR="#000000">In my board, I had ignored this.</FONT>
<FONT COLOR="#000000"><snip></FONT>
<FONT COLOR="#000000">> structure that includes all bus information:</FONT>
<FONT COLOR="#000000">> </FONT>
<FONT COLOR="#000000">> typedef struct _i2c_bus</FONT>
<FONT COLOR="#000000">> {</FONT>
<FONT COLOR="#000000">> int baseAddress</FONT>
<FONT COLOR="#000000">> int busSpeed;</FONT>
<FONT COLOR="#000000">> uchar noProbeList[];</FONT>
<FONT COLOR="#000000">> ... /* whatever else might be useful */</FONT>
<FONT COLOR="#000000">> } i2c_bus;</FONT>
<FONT COLOR="#000000">> </FONT>
<FONT COLOR="#000000">If we keep the following requirements:</FONT>
<FONT COLOR="#000000">1. We don't want to modify implementations of NOPROBE for all previous</FONT>
<FONT COLOR="#000000">drivers</FONT>
<FONT COLOR="#000000">2. as less intrusive change as possible to cmd_i2c.c.</FONT>
<FONT COLOR="#000000">Two approaches appear to me:</FONT>
<FONT COLOR="#000000">1. use additional set_i2c_ignore cmd to select the ignore list/even make</FONT>
<FONT COLOR="#000000">CFG_I2C_NOPROBES indexed on busses.</FONT>
<FONT COLOR="#000000">+ve, minimal change to cmd_i2c.c,</FONT>
<FONT COLOR="#000000">-ve - will be patch on..</FONT>
<FONT COLOR="#000000">2. The structure defined as you gave it</FONT>
<FONT COLOR="#000000">+ve - cleaner</FONT>
<FONT COLOR="#000000">-ve - multiple changes to config files+ additional implementation to all</FONT>
<FONT COLOR="#000000">legacy boards.</FONT>
<FONT COLOR="#000000">My view: I'd go with option 1. Primarily coz I suspect half our</FONT>
<FONT COLOR="#000000">community might be too busy to go back and change and test all previous</FONT>
<FONT COLOR="#000000">implementations.</FONT>
<FONT COLOR="#000000">Regards,</FONT>
<FONT COLOR="#000000">Nishanth Menon</FONT>
<FONT COLOR="#000000">-------------------------------------------------------</FONT>
<FONT COLOR="#000000">Using Tomcat but need to do more? Need to support web services, security?</FONT>
<FONT COLOR="#000000">Get stuff done quickly with pre-integrated technology to make your job easier</FONT>
<FONT COLOR="#000000">Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo</FONT>
<FONT COLOR="#000000"><A HREF="http://sel.as-us.falkag.net/sel?cmd=lnk&kid">http://sel.as-us.falkag.net/sel?cmd=lnk&kid</A>0709&bid&3057&dat1642</FONT>
<FONT COLOR="#000000">_______________________________________________</FONT>
<FONT COLOR="#000000">U-Boot-Users mailing list</FONT>
<FONT COLOR="#000000"><A HREF="mailto:U-Boot-Users@lists.sourceforge.net">U-Boot-Users@lists.sourceforge.net</A></FONT>
<FONT COLOR="#000000"><A HREF="https://lists.sourceforge.net/lists/listinfo/u-boot-users">https://lists.sourceforge.net/lists/listinfo/u-boot-users</A></FONT>
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>