<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.8.1">
</HEAD>
<BODY>
I'm working on a solution that retains NOPROBE support, while keeping the footprint as small as possible. Should have a patch tomorrow.<BR>
<BR>
regards,<BR>
Ben<BR>
<BR>
On Tue, 2006-05-16 at 22:15 +0200, Wolfgang Denk wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
<FONT COLOR="#000000">In message <<A HREF="mailto:1147798734.16780.201.camel@saruman.qstreams.net">1147798734.16780.201.camel@saruman.qstreams.net</A>> you wrote:</FONT>
<FONT COLOR="#000000">> One sticky part is, how do we deal with the 'CFG_I2C_NOPROBE' stuff?</FONT>
<FONT COLOR="#000000">> This is a list defined for each board of chips that the 'iprobe' command</FONT>
<FONT COLOR="#000000">> should bypass. The current implementation has this list instantiated as</FONT>
<FONT COLOR="#000000">> a static array within 'cmd_i2c.c', and is of course relevant only to the</FONT>
<FONT COLOR="#000000">> first bus. As we add buses, it gets ugly. How about defining a</FONT>
<FONT COLOR="#000000">> structure that includes all bus information:</FONT>
<FONT COLOR="#000000">> </FONT>
<FONT COLOR="#000000">> typedef struct _i2c_bus</FONT>
<FONT COLOR="#000000">> {</FONT>
<FONT COLOR="#000000">> int baseAddress</FONT>
<FONT COLOR="#000000">> int busSpeed;</FONT>
<FONT COLOR="#000000">> uchar noProbeList[];</FONT>
<FONT COLOR="#000000">> ... /* whatever else might be useful */</FONT>
<FONT COLOR="#000000">> } i2c_bus;</FONT>
<FONT COLOR="#000000">Please keep as small as possible.</FONT>
<FONT COLOR="#000000">> On the other hand, maybe the NOPROBE list is rarely used and we</FONT>
<FONT COLOR="#000000">> shouldn't be worrying too much about it.</FONT>
<FONT COLOR="#000000">Ummm... at least the following board configurations use it:</FONT>
<FONT COLOR="#000000">include/configs/MPC8540ADS.h</FONT>
<FONT COLOR="#000000">include/configs/MPC8541CDS.h</FONT>
<FONT COLOR="#000000">include/configs/MPC8555CDS.h</FONT>
<FONT COLOR="#000000">include/configs/MPC8560ADS.h</FONT>
<FONT COLOR="#000000">include/configs/PM854.h</FONT>
<FONT COLOR="#000000">include/configs/SBC8540.h</FONT>
<FONT COLOR="#000000">include/configs/SBC8560.h</FONT>
<FONT COLOR="#000000">include/configs/XPEDITE1K.h</FONT>
<FONT COLOR="#000000">include/configs/bubinga.h</FONT>
<FONT COLOR="#000000">include/configs/ebony.h</FONT>
<FONT COLOR="#000000">include/configs/ocotea.h</FONT>
<FONT COLOR="#000000">include/configs/sbc8560.h</FONT>
<FONT COLOR="#000000">include/configs/stxgp3.h</FONT>
<FONT COLOR="#000000">include/configs/MPC8540EVAL.h</FONT>
<FONT COLOR="#000000">include/configs/MPC8548CDS.h</FONT>
<FONT COLOR="#000000">include/configs/PM856.h</FONT>
<FONT COLOR="#000000">include/configs/KAREF.h</FONT>
<FONT COLOR="#000000">include/configs/METROBOX.h</FONT>
<FONT COLOR="#000000">include/configs/TQM85xx.h</FONT>
<FONT COLOR="#000000">include/configs/p3p440.h</FONT>
<FONT COLOR="#000000">include/configs/MPC8349EMDS.h</FONT>
<FONT COLOR="#000000">That's definitely more than "rarely used".</FONT>
<FONT COLOR="#000000">Best regards,</FONT>
<FONT COLOR="#000000">Wolfgang Denk</FONT>
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>