<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.8.1">
</HEAD>
<BODY>
Thanks Wolfgang. <BR>
<BR>
I have no idea how you got this again - strange things are afoot with the sourceforge mailing list. Anyway, I'll be on the lookout for traling white space in future submissions.<BR>
<BR>
regards,<BR>
Ben<BR>
<BR>
On Thu, 2006-05-18 at 00:24 +0200, Wolfgang Denk wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
<FONT COLOR="#000000">In message <<A HREF="mailto:1147723625.16780.140.camel@saruman.qstreams.net">1147723625.16780.140.camel@saruman.qstreams.net</A>> you wrote:</FONT>
<FONT COLOR="#000000">> </FONT>
<FONT COLOR="#000000">> Attached is a patch to common/cmd_i2c.c that allows access to two I2C</FONT>
<FONT COLOR="#000000">> controllers on a board. Note that this doesn't actually change any</FONT>
<FONT COLOR="#000000">> hardware control - it just enhances the command set and passes more</FONT>
<FONT COLOR="#000000">> information to whatever version of i2c_read(), i2c_write() etc. that</FONT>
<FONT COLOR="#000000">> you're using. I've implemented driver changes on MPC8349 hardware, but</FONT>
<FONT COLOR="#000000">> they're not quite ready for review yet. New definitions:</FONT>
<FONT COLOR="#000000">> CONFIG_I2C_2_CTRLS - board has two I2C controllers</FONT>
<FONT COLOR="#000000">> CFG_I2C2_NOPROBES {} - list of devices on bus 2 to ignore when probing</FONT>
<FONT COLOR="#000000">> </FONT>
<FONT COLOR="#000000">> CHANGELOG: </FONT>
<FONT COLOR="#000000">> If CONFIG_I2C_2_CTRLS is defined, the 'chip' parameter of all I2C</FONT>
<FONT COLOR="#000000">> commands will accept an optional controller argument. </FONT>
<FONT COLOR="#000000">> e.g. 'imd 50.1 0' displays data at offset 0 of controller 1 device 50</FONT>
<FONT COLOR="#000000">> 'imd 50.2 0' displays data at offset 0 of controller 2 device 50</FONT>
<FONT COLOR="#000000">> 'iprobe 2' probes for devices on the second bus</FONT>
<FONT COLOR="#000000">I reject this patch.</FONT>
<FONT COLOR="#000000">As discussed before, I don't like the command format. Second, what</FONT>
<FONT COLOR="#000000">happens if there comes a board with 3 I2C busses? Then we touch the</FONT>
<FONT COLOR="#000000">code gain... No, thanks.</FONT>
<FONT COLOR="#000000">Also note that your patch has trailing white space, so it violates</FONT>
<FONT COLOR="#000000">the coding standard.</FONT>
<FONT COLOR="#000000">Best regards,</FONT>
<FONT COLOR="#000000">Wolfgang Denk</FONT>
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>