<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7650.21">
<TITLE>An obvious bug in cpu/s3c44b0/serial.c</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/rtf format -->
<P><FONT SIZE=2 FACE="Arial">Hi there</FONT>
</P>
<P><FONT SIZE=2 FACE="Arial">there is an obvious bug in cpu/s3c44b0/serial.c (1.1.4)</FONT>
<BR><FONT SIZE=2 FACE="Arial">Now I am unable to download the latest version to check(1.2.0?)</FONT>
<BR><FONT SIZE=2 FACE="Arial">Is it corrected?</FONT>
</P>
<P><FONT SIZE=2 FACE="Arial">********************************************************</FONT>
</P>
<P><FONT SIZE=2 FACE="Arial">void serial_setbrg (void)</FONT>
<BR> <FONT SIZE=2 FACE="Arial">DECLARE_GLOBAL_DATA_PTR;</FONT>
</P>
<P> <FONT SIZE=2 FACE="Arial">u32 divisor = 0;</FONT>
</P>
<P> <FONT SIZE=2 FACE="Arial">/* get correct divisor */</FONT>
<BR> <FONT SIZE=2 FACE="Arial">switch(gd->baudrate) {</FONT>
</P>
<P> <FONT SIZE=2 FACE="Arial">case 1200:</FONT>
<BR><FONT SIZE=2 FACE="Arial">#if CONFIG_S3C44B0_CLOCK_SPEED==66</FONT>
<BR> <FONT SIZE=2 FACE="Arial">divisor = 3124;</FONT>
<BR><FONT SIZE=2 FACE="Arial">#elif CONFIG_S3C44B0_CLOCK_SPEED==75</FONT>
<BR> <FONT SIZE=2 FACE="Arial">divisor = 3905;</FONT>
<BR><FONT SIZE=2 FACE="Arial">#else</FONT>
<BR><FONT SIZE=2 FACE="Arial"># error CONFIG_S3C44B0_CLOCK_SPEED undefined</FONT>
<BR><FONT SIZE=2 FACE="Arial">#endif</FONT>
<BR> <FONT SIZE=2 FACE="Arial">break;</FONT>
</P>
<BR>
<P><FONT SIZE=2 FACE="Arial">…….</FONT>
</P>
<BR>
<P> <FONT SIZE=2 FACE="Arial">case 38400:</FONT>
<BR><FONT SIZE=2 FACE="Arial">#if CONFIG_S3C44B0_CLOCK_SPEED==66</FONT>
<BR> <FONT SIZE=2 FACE="Arial">divisor = 97;</FONT>
<BR><FONT SIZE=2 FACE="Arial">#elif CONFIG_S3C44B0_CLOCK_SPEED==75</FONT>
<BR> <FONT SIZE=2 FACE="Arial">divisor = 121;</FONT>
<BR><FONT SIZE=2 FACE="Arial">#else</FONT>
<BR><FONT SIZE=2 FACE="Arial"># error CONFIG_S3C44B0_CLOCK_SPEED undefined</FONT>
<BR><FONT SIZE=2 FACE="Arial">#endif <U><B> </B></U></FONT><U><B><FONT COLOR="#FF0000" SIZE=2 FACE="Arial">/* break; */</FONT></B></U>
</P>
<BR>
<P><U><B><FONT COLOR="#FF0000" SIZE=2 FACE="Arial">Why it is commented?</FONT></B></U><B></B>
</P>
<P> <FONT SIZE=2 FACE="Arial">case 57600:</FONT>
<BR><FONT SIZE=2 FACE="Arial">#if CONFIG_S3C44B0_CLOCK_SPEED==66</FONT>
<BR> <FONT SIZE=2 FACE="Arial">divisor = 64;</FONT>
<BR><FONT SIZE=2 FACE="Arial">#elif CONFIG_S3C44B0_CLOCK_SPEED==75</FONT>
<BR> <FONT SIZE=2 FACE="Arial">divisor = 80;</FONT>
<BR><FONT SIZE=2 FACE="Arial">#else</FONT>
<BR><FONT SIZE=2 FACE="Arial"># error CONFIG_S3C44B0_CLOCK_SPEED undefined</FONT>
<BR><FONT SIZE=2 FACE="Arial">#endif /* break; */</FONT>
</P>
<BR>
<BR>
<BR>
<BR>
<P><SPAN LANG="en-us"><FONT SIZE=2 FACE="Arial">Best Regards</FONT></SPAN><SPAN LANG="zh-cn"> </SPAN>
<BR><SPAN LANG="en-us"><FONT SIZE=2 FACE="Arial">ZhouRui</FONT></SPAN><SPAN LANG="zh-cn"></SPAN>
</P>
<BR>
<BR>
<BR>
</BODY>
</HTML>