<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.2900.3020" name=GENERATOR></HEAD>
<BODY>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007>Dear All
</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=464162111-12032007></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007>I'd like some
guidance here:-</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=464162111-12032007></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007>An arm patch for a
new board has been submitted. </SPAN></FONT><FONT face=Arial size=2><SPAN
class=464162111-12032007>Part of the patch is to add the new
file:-</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=464162111-12032007></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN
class=464162111-12032007>include/asm-arm/arch-arm1176/bits.h<BR></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007>defining standard
bit shifts e.g</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=464162111-12032007></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007>#define BIT0
(1<<0)<BR>#define BIT1 (1<<1)<BR>#define BIT2
(1<<2)<BR>#define BIT3 (1<<3)<BR>#define BIT4
(1<<4)<BR>#define BIT5 (1<<5)<BR></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007>I notice there is
already a file:-</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=464162111-12032007></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>include/asm-arm/arch-arm113/bits.h</SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007></SPAN></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>with identical contents.</SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007></SPAN></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>a) Is it acceptable to replace these two (and
references thereto) with </SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>include/bitshifts.h?</SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007></SPAN></SPAN></FONT><FONT face=Arial size=2><SPAN
class=464162111-12032007><SPAN
class=464162111-12032007></SPAN></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>The shifts are not arm specific, and could be useful to
others.</SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007></SPAN></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>b) If so, should I submit a seperate patch to the main
tree, or is it acceptable to make this part of the</SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>patch for the new board?</SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007></SPAN></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>Regards</SPAN></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007></SPAN></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=464162111-12032007><SPAN
class=464162111-12032007>Peter </DIV>
<DIV><BR></DIV></SPAN></SPAN></FONT>
<DIV><FONT face=Arial size=2><SPAN
class=464162111-12032007> </DIV></SPAN></FONT></BODY></HTML>