<br><div><span class="gmail_quote">2007/4/9, Wolfgang Denk <<a href="mailto:wd@denx.de">wd@denx.de</a>>:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Dear Ilya,<br><br>in message <<a href="mailto:8496f91a0704080420m1e72900cn70116c3dc7973b2b@mail.gmail.com">8496f91a0704080420m1e72900cn70116c3dc7973b2b@mail.gmail.com</a>> you wrote:<br>><br>> This patch adds support for MC68360 based board for
u-boot-1.1.6. Mail me if<br>> you have any questions :)<br><br>Please correct me if I'm wrong, but MC68360 is not the name of a<br>board, but of the Freescale (resp. ex Motorola) QICC CPU. There are<br>many different boards using this processor, so you will have to chose
<br>a more descriptive board name.</blockquote><div><br>Yes, you are right. MC68360 is the name of the CPU. But the board I'm working<br>at right now is my own design. That's why I can't do it.<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Also, U-Boot 1.1.6 is outdated. Please submit your patch against a<br>recent version of U-Boot (i. e. top of tree in git repository, or at<br>least release 1.2.0).</blockquote><div><br>Ooops, I was not aware of it. As far as I know, there was no official information about it.
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Then, there are some coding style issues with your patch (indentation<br>not by TAB, indentation not by multiple of 8 columns, trailing white
<br>space, C++ comments, too long lines, etc.) as well as other formal<br>issues (missing Copyright entries, missing license headers, missing<br>Signed-off-by: line).</blockquote><div><br>Ok. Could you tell me where I can get exact information about it?
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">It seems you use a private flash driver for a device that looks as if<br>it was CFI conformant. Please explain why you cannot use the CFI
<br>driver instead.</blockquote><div><br>This is because I have old non-CFI flash chips :(<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I also wonder if you really need a new ethernet driver<br>(cpu/mc68360/enet.c) and a new serial driver (cpu/mc68360/serial.c) -<br>IIRC the CPM on the 360 is mostly compatible (with very few minor<br>deviations that can be handled easily) to the CPM on the PowerQICC I
<br>(= MPC8xx) processors. I think most of this could could (and should)<br>be shared? The same holds for some other files like for example<br>include/asm-m68k/arch-mc68360/commproc.h which is highly redundand<br>
with the MPC8xx commproc.h</blockquote><div><br>I don't know this processors family well enough, but I see what I can do with it....<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Some of your files contain version ID stuff like here:<br><br>include/asm-m68k/arch-mc68360/mc68360_enet.h:<br><br> ***********************************<br> * $Id: m68360_enet.h,v <a href="http://1.1.1.1">1.1.1.1
</a> 2001/05/18 17:10:11 hamilton Exp $<br> ***********************************<br><br>Please remove this.</blockquote><div><br>ok <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I see some "#if 0" blocks in your code; please remove these.</blockquote><div><br>ok <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I see:<br><br> #define CONFIG_BOOTFILE vmlinuz<br><br>This looks broken to me. U-Boot does not boot a vmlinuz file, but<br>U-Boot images created by mkimage.</blockquote><div><br>Yes, this name is incorrect... Let it be uImage.
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">#define CFG_BAUDRATE_TABLE { 19200 }<br><br>This is *very* restrictive. I recommend to support all commonly used
<br>baudrates instead (i. e. at least the range from 9600 through<br>115200).</blockquote><div><br>ok <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
#define CFG_HZ (unsigned long int)32768000<br><br>This is broken. CFG_HZ is required to be 1000 (i. e. millisecond<br>ticks).</blockquote><div><br>okkk.. <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
#define CFG_SDRAM_SIZE 0x00800000<br><br>Please don't do that. U-Boot style is to allow auto-adjustment to the<br>actual RAM size.<br><br><br>#define CFG_MALLOC_LEN (5*1024*1024)<br><br>
You have 8 MB of RAM and reserve 5 MB for malloc()? This seems broken<br>to me.</blockquote><div><br>Why not? I really have it working :) <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
You comment out relevant parts of lib_m68k/board.c - you must not do<br>that!</blockquote><div><br>Could you tell me the reason why I should not do it?<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
lib_m68k/time.c - your "implementation" of udelay() is broken. Please<br>replace by a working version.</blockquote><div><br>I'll try. <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Please clean up these issues and resubmit.<br><br></blockquote></div><br>I'm grateful to you for your help and for what you are doing :)<br><br>I will take into consideration your advice and recommendations. And I'll try to correct my patch.
<br><br>Best regards,<br>Matvejchikov Ilya.<br><br>