<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7653.2">
<TITLE>RE: [PATCH V2 0/9] SATA framework and FSL SATA support patch set</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>Your message is extremely difficult to read. Can you please use proper<BR>
quoting? Please read <A HREF="http://www.netmeister.org/news/learn2quote.html">http://www.netmeister.org/news/learn2quote.html</A><BR>
if you need help...<BR>
<BR>
[dave] sorry for that, I'm using the webmail to access my mailbox.<BR>
the webmail is stupid.<BR>
<BR>
<BR>
> [dave]the common/cmd_sata.c is more likely controller specificed driver, not<BR>
> sata framework. the cmd_sata2.c is more generic. can connect to different SATA<BR>
> controller driver.<BR>
<BR>
Maybe. But still both the existing common/cmd_sata.c and your new<BR>
cmd_sata2.c implement the very same functions (like do_sata()) with<BR>
more or less the same sub-commands etc.<BR>
<BR>
[dave] I think the same part is focusing on command line.<BR>
<BR>
> I think this needs to be cleaned up. I will not accept multiple<BR>
> similar but conflicting implementations of the very same functions.<BR>
><BR>
> [dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.<BR>
<BR>
Sorry, but this will not work. I will not add such duplicated code.<BR>
Please add command level stuff to the (existing) common/cmd_sata.c<BR>
file and do not add any new cmd_sata2.c which duplicates it. If<BR>
necessary, clean up the code while you're there.<BR>
<BR>
[dave] if I choose current command/cmd_sata.c, and don't move the drivers part of<BR>
cmd_sata.c to drivers/block. I think it will add extra-space for my image.<BR>
so, the best choice is move the drivers part of cmd_sata.c to drivers/block.<BR>
what do you think about it?<BR>
</FONT>
</P>
</BODY>
</HTML>