<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7653.2">
<TITLE>RE: [PATCH V2 0/9] SATA framework and FSL SATA support patch set</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<BR>
<BR>
<BR>
<P><FONT SIZE=2>-----Original Message-----<BR>
From: Wolfgang Denk [<A HREF="mailto:wd@denx.de">mailto:wd@denx.de</A>]<BR>
Sent: Wed 3/26/2008 7:58 AM<BR>
To: Liu Dave<BR>
Cc: u-boot-external; Phillips Kim<BR>
Subject: Re: [PATCH V2 0/9] SATA framework and FSL SATA support patch set<BR>
<BR>
Dear Dave,<BR>
<BR>
in message <1206008182.3739.6.camel@localhost.localdomain> you wrote:<BR>
><BR>
> The patch set include two parts:<BR>
> 1. SATA framework support<BR>
> 2. The Freescale SATA controller support<BR>
...<BR>
> Dave Liu (8):<BR>
> ATA: Add the support for SATA framework<BR>
<BR>
Why add new support? We already have some...<BR>
<BR>
[dave] really, I didn't find any SATA framework support in u-boot.<BR>
if you are saying the cmd_sata.c. I don't agree it.<BR>
<BR>
<BR>
> board/freescale/mpc837xemds/mpc837xemds.c | 3 +<BR>
> common/Makefile | 1 +<BR>
> common/cmd_sata2.c | 206 +++++++<BR>
<BR>
Can you please explain why we need a new file common/cmd_sata2.c<BR>
which duplicates a lot of functions of the already existing<BR>
common/cmd_sata.c ?<BR>
<BR>
[dave]the common/cmd_sata.c is more likely controller specificed driver, not<BR>
sata framework. the cmd_sata2.c is more generic. can connect to different SATA<BR>
controller driver.<BR>
<BR>
<BR>
I think this needs to be cleaned up. I will not accept multiple<BR>
similar but conflicting implementations of the very same functions.<BR>
<BR>
[dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.<BR>
<BR>
</FONT>
</P>
</BODY>
</HTML>