<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Tor,<br>
<br>
after all my VSC8601 is up and running on MPC8343 :-)<br>
<br>
I'm sorry to say that I don't find this patch ok after going through
the manuals :<br>
<br>
Register 0x17 is a very coarse setting. If the capabilities of the PHY
should be taken into account and be configurable we should use the skew
control in extended register 0x1c. This should be definable -
CFG_VSC8601_SKEWFIX simply applies maximum skew ...<br>
<br>
After all changing the bits in register 0x17 _require_ a soft reset by
asserting bit 15 in register 0 before they are going to work.<br>
<br>
Obviously this patch has no effect at all. <br>
Do you reset the PHY manually after this configuration ?<br>
<br>
This PHY definitely needs a proper setup function since there are quite
interesting registers which need read-modify-write.<br>
<br>
<br>
What do you think ?<br>
<br>
<br>
regards,<br>
Andre<br>
<br>
Kim Phillips schrieb:
<blockquote
cite="mid:20080331131830.bdd5c146.kim.phillips@freescale.com"
type="cite">
<pre wrap="">On Mon, 31 Mar 2008 10:01:34 -0400
Ben Warren <a class="moz-txt-link-rfc2396E" href="mailto:biggerbadderben@gmail.com"><biggerbadderben@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Tor Krill wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Add phy_info for Vitesse VSC8601.
Add config option, CFG_VSC8601_SKEWFIX, to enable RGMII skew timing compensation.
Signed-off-by: Tor Krill <a class="moz-txt-link-rfc2396E" href="mailto:tor@excito.com"><tor@excito.com></a>
</pre>
</blockquote>
<pre wrap="">Acked-by: Ben Warren <a class="moz-txt-link-rfc2396E" href="mailto:biggerbadderben@gmail.com"><biggerbadderben@gmail.com></a>
</pre>
</blockquote>
<pre wrap=""><!---->
I don't have a Vitesse 8601, so technically I can't ack it, but I can:
Reviewed-by: Kim Phillips <a class="moz-txt-link-rfc2396E" href="mailto:kim.phillips@freescale.com"><kim.phillips@freescale.com></a>
minor nit: it would be nice if the following:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">+#ifdef CFG_VSC8601_SKEWFIX
+ {MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL},
+#endif
</pre>
</blockquote>
</blockquote>
<pre wrap=""><!---->
were made to have spaces after commas, and flow onto a separate
line so as to not be a 96 char line..
Kim
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
<a class="moz-txt-link-freetext" href="http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace">http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace</a>
_______________________________________________
U-Boot-Users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:U-Boot-Users@lists.sourceforge.net">U-Boot-Users@lists.sourceforge.net</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/u-boot-users">https://lists.sourceforge.net/lists/listinfo/u-boot-users</a>
</pre>
</blockquote>
<br>
<BR>
MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
<BR>
</body>
</html>