yes - you are correct<br><br>thank you<br><br><div class="gmail_quote">On Tue, May 13, 2008 at 7:18 PM, Shinya Kuribayashi <<a href="mailto:skuribay@ruby.dti.ne.jp">skuribay@ruby.dti.ne.jp</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">Eyal Bari wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
in your version of the function the iterated cache ops second argument was start_addr which stay constant.<br>
</blockquote>
<br></div>
Probably already fixed in the latest git. See below commit:<br>
<br>
<a href="http://git.denx.de/?p=u-boot.git;a=commitdiff;h=188e94c370621708d13547d58dbc6ed3c5602aa8" target="_blank">http://git.denx.de/?p=u-boot.git;a=commitdiff;h=188e94c370621708d13547d58dbc6ed3c5602aa8</a><div class="Ih2E3d">
<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
the second bug is that it doesn't iterate over the entire range:<br>
for example:<br>
if size is 42 and the cache line size is 32 - it takes two cache lines to cache this buffer<br>
your version will iterate only over one cache line<br>
my version will iterate over two cache line covering the entire range<br>
</blockquote>
<br></div>
Note that (addr == aend) is evaluated *after* cache_op()s.<br>
<br>
If start_addr = 0x80000000, size = 42, CFG_CACHE_LINE_SIZE = 32,<br>
cache_op( , 0x80000000) and cache_op( , 0x80000020) will be done.<br>
I hope I don't miss anything.<br>
<br>
</blockquote></div><br>