<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7653.2">
<TITLE>RE: [U-Boot-Users] [PATCH 4/8] New board SIMPC8313 support: support forbooting from NAND in start.S</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>> diff --git a/cpu/mpc83xx/start.S b/cpu/mpc83xx/start.S<BR>
> index 309eb30..39bcaa8 100644<BR>
> --- a/cpu/mpc83xx/start.S<BR>
> +++ b/cpu/mpc83xx/start.S<BR>
> @@ -63,6 +63,9 @@<BR>
> * Use r14 to access the GOT<BR>
> */<BR>
> START_GOT<BR>
> +#if defined(CONFIG_NAND_SPL)<BR>
> + GOT_ENTRY(_GOT_TABLE_)<BR>
> +#else<BR>
> GOT_ENTRY(_GOT2_TABLE_)<BR>
> GOT_ENTRY(_FIXUP_TABLE_)<BR>
> <BR>
> @@ -74,6 +77,7 @@<BR>
> GOT_ENTRY(__init_end)<BR>
> GOT_ENTRY(_end)<BR>
> GOT_ENTRY(__bss_start)<BR>
> +#endif /* CONFIG_NAND_SPL */<BR>
> END_GOT<BR>
> <BR>
> [Dave] I strongly suggest we create one lite new start.S for the NAND boot,<BR>
> not modify the original start.S<BR>
<BR>
I'd prefer otherwise, if we can keep the #ifdeffing to a minimum.<BR>
<BR>
[Dave] The new start.S for NAND boot should be very lite. same things<BR>
for 85xx/86xx, creating new start.S for e500/e600 for NAND boot.<BR>
I don't like some much #ifdefine n the start.S which has not good readable.<BR>
</FONT>
</P>
</BODY>
</HTML>