<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Kim Phillips wrote:
<blockquote
cite="mid:20080708162042.4519e782.kim.phillips@freescale.com"
type="cite">
<pre wrap="">On Tue, 08 Jul 2008 16:35:00 +0200
Andre Schwarz <a class="moz-txt-link-rfc2396E" href="mailto:andre.schwarz@matrix-vision.de"><andre.schwarz@matrix-vision.de></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Kim,
I forgot to mention that both fpga.c are _not_ the same.
They are using different FPGA sizes _and_ different I/Os on different cpu.
</pre>
</blockquote>
<pre wrap=""><!---->
the size is a one-line thing that can be easily and understandably
#ifdeffed. The gpio struct difference can be fixed like this:
static u32 get_dvo()
{
#ifdef CONFIG_MPC83XX
volatile immap_t *im = (volatile immap_t *)CFG_IMMR;
volatile gpio83xx_t *gpio = (volatile gpio83xx_t *)&im->gpio[0];
return gpio->dat;
#else
#ifdef CONFIG_MPC5XXX
struct mpc5xxx_gpio *gpio = (struct mpc5xxx_gpio*)MPC5XXX_GPIO;
return gpio->simple_dvo;
#endif
#endif
}
...and subsequently use get_dvo() later in the file.
</pre>
</blockquote>
ok - you're right.<br>
Will fix it along with other out_* issues.<br>
<blockquote
cite="mid:20080708162042.4519e782.kim.phillips@freescale.com"
type="cite">
<pre wrap=""></pre>
<blockquote type="cite">
<pre wrap="">It's not possible for me to use a common file for the short term.
Maybe later when the FPGA interface got mature ...
</pre>
</blockquote>
<pre wrap=""><!---->
I really think code maintenance will suffer if you don't do it now;
afaict, the file is functionally equal modulo the size one-liner.
Kim
</pre>
</blockquote>
yes - thanks for persuading :-)<br>
<br>
<BR>
MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
<BR>
</body>
</html>