<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.18.2">
</HEAD>
<BODY>
On mer, 2008-07-09 at 09:25 -0400, Timur Tabi wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Jul 7, 2008, at 10:17 AM, Luigi 'Comio' Mantellini wrote:
> ---
> drivers/i2c/fsl_i2c.c | 68 ++++++++++++++++++++++++++++++++++++++++
> +++++++++
> 1 files changed, 68 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
> index 0690340..8fd73c0 100644
> --- a/drivers/i2c/fsl_i2c.c
> +++ b/drivers/i2c/fsl_i2c.c
> @@ -78,6 +78,73 @@ static const struct fsl_i2c *i2c_dev[2] = {
</PRE>
</BLOCKQUOTE>
...
<BLOCKQUOTE TYPE=CITE>
<PRE>
> + {.fdr=0x3B, .divider=1024}, {.fdr=0x18, .divider=1152},
> {.fdr=0x19, .divider=1280},
> + /*{.fdr=0x3C, .divider=1280},*/ {.fdr=0x1A, .divider=1536}, /
> *{.fdr=0x3D, .divider=1536},*/
</PRE>
</BLOCKQUOTE>
....
<BLOCKQUOTE TYPE=CITE>
<PRE>
NAK. There's a better way to do this. Don't just copy/paste my data
structures and comment-out specific fields like this.
</PRE>
</BLOCKQUOTE>
<BR>
The values are from the 547x manual because the fsl_i2c on coldfire is a little different (e.g. there isn't the default filter register).<BR>
The entries commented are just synonymous of others. For example the divider 1280 can be obtained using both the fdr values 0x19 and 0x3C (always on coldfire cpus). <BR>
<BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
I'm on vacation this week. Next week, I'll take a closer look at your
patch and suggest something better.
</PRE>
</BLOCKQUOTE>
<BR>
Thanks, I just reported a problem (i think)... the patches is just the quick solution that I have adopted on my application.<BR>
<BR>
Best regards and have a good vacation!<BR>
<BR>
<BR>
luigi<BR>
<BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
What is the reason you are commenting-out those specific entries in
fsl_i2c_speed_map[]?
</PRE>
</BLOCKQUOTE>
<BR>
<BR>
<BR>
<BR>
<TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
<TABLE CELLSPACING="14">
<TR>
<TD>
<A HREF="http://www.idf-hit.com"><IMG SRC="cid:1215610249.6982.35.camel@localhost" ALIGN="bottom" ALT="Industrie Dial Face S.p.A." BORDER="0"></A>
</TD>
<TD>
<B>Luigi Mantellini</B><BR>
R&D - Software<BR>
<TT>Industrie Dial Face S.p.A.</TT><BR>
<TT>Via Canzo, 4 </TT><BR>
<TT>20068 Peschiera Borromeo (MI), Italy</TT><BR>
<TT>Tel.: +39 02 5167 2813</TT><BR>
<TT>Fax: +39 02 5167 2459</TT><BR>
<TT>E-mail: <A HREF="mailto:luigi.mantellini@idf-hit.com">luigi.mantellini@idf-hit.com</A></TT><BR>
<TT>GPG fingerprint: 3DD1 7B71 FBDF 6376 1B4A</TT><BR>
<TT> B003 175F E979 907E 1650</TT>
</TD>
</TR>
</TABLE>
</TD>
</TR>
</TABLE>
</BODY>
</HTML>