<HTML dir=ltr><HEAD><TITLE>Re: [U-Boot-Users] [PATCH] PPC4xx: Memory Queue Optimizations for PPC460EX/GT</TITLE>
<META http-equiv=Content-Type content="text/html; charset=unicode">
<META content="MSHTML 6.00.2900.3354" name=GENERATOR></HEAD>
<BODY>
<DIV id=idOWAReplyText28878 dir=ltr>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>Thanks Stefan for your comments. Please see reply below.</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>>> + mtdcr(plb1_acr, plb1_acr_ppm_fair |<BR>>> + plb1_acr_hbu_enabled |<BR>>> + plb1_acr_rdp_4deep |<BR>>> + plb1_acr_wrp_2deep);<BR>>> +<BR>><BR>>Is this PLB0_ACR tuning Canyonlands specific? Or will all 460EX/GT boards<BR>>profit from this configuration? Or even other 4xx PPC variants as well?<BR>><BR>>If this is the case then I suggest to move this code to a common place,<BR>>perhaps in cpu_init_f(). What do you think?</FONT></DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>The PLB Arbiter register configuration are definitely common to PPC460EX/GT boards.<BR>I am working with PowerPC hardware architects to find out whether we can put the same<BR>changes for other PPC4xx variants</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>>> +<BR>>> + mtdcr(SDRAM_CONF1HB, 0x80001c80);<BR>>> + mtdcr(SDRAM_CONF1LL, 0x80001c80);<BR>>> + mtdcr(SDRAM_CONFPATHB, 0x18a68000);<BR>><BR>>Could you please add a comment what exactly is configured with these "magic<BR>>numbers"?</FONT></DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>I will add C defines corresponding to those register bits and resubmit</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>>> +#if defined(CONFIG_440EP) || defined(CONFIG_440GR) || \<BR>>> + defined(CONFIG_440EPX) || defined(CONFIG_440GRX) || \<BR>>> + defined(CONFIG_460EX) || defined(CONFIG_460GT)<BR>><BR>>Are the PLBx_ACR register really identical on all those PPC's? Just checking.</FONT></DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>They seem to be so. I will double-check the user manuals for all these processors.</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>>Please fix if necessary and resubmit. And please keep me on CC on 4xx related<BR>>patches.</FONT></DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>I will try to put out the modified patch latest by tommorow.</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>Best Regards,<BR>Prodyut Hazarika</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>================================<BR>Staff S/W Engineer<BR>AMCC<BR>================================</FONT></DIV></DIV>
<DIV dir=ltr><FONT size=3></FONT> </DIV></BODY></HTML>