[ELDK] [PATCH 1/3] m28evk-specific-support

[Stefano Babic]

Hi Wolfgang,

On 18/10/2013 10:15, Wolfgang Denk wrote:
> Hallo Lothar,
> 
> In message <1379077965-6435-2-git-send-email-l.rubusch at gmx.ch> you wrote:
>> m28evk support:
>> linux-eldk 3.8; sdcard image with u-boot, uImage / FDT and rootfs (ext);
>> elftosb; a patch for a corresponding u-boot m28evk.h and settings for mkimage
>> (native)
> ...
> 
>> diff --git a/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb b/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb
>> index 9545166..a4bf1ad 100644
>> --- a/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb
>> +++ b/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb
> ...
>> -LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb \
>> -                    file://README;beginline=1;endline=22;md5=78b195c11cb6ef63e6985140db7d7bab"
>> -SECTION = "bootloader"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
> 
> Warum hast Du hier die Prüfung des  file://README  rausgemacht?

Do we switch to german for this mailing list ?


>> +do_compile_append_m28evk(){
>> +    ## linux.inc copies Image to uImage if it is present, this may be a bug in linux.inc
>> +    [[ -e ${WORKDIR}/git/arch/arm/boot/Image ]] && rm ${WORKDIR}/git/arch/arm/boot/Image
>> +}
> 
> Ich glaube, ich hatte das schon einmal gefragt: diese MACHINE-spezifi-
> schen Dinge kann man nicht irgendwo in einem MACHINE-spezifischen File
> (evtl. einem .bbappend ?) halten?  Ich sehe das Problem, daß das so
> nicht skaliert - stell Dir vor, wir haben eines Tages 200 Boards in
> der List, alle mit verschiedenen Anforderungen...

Agree, this does not scale at all. Anyway, I am asking which is the way
to do. A .bbappend works fine if the .bbappend file is put in a separate
layer - I did several times, and there are a lot of examples in
meta-<manufacturer name>.

But if the file is still in meta-eldk, it will be always included. So
one way could be to add a new layer with recipes-bsp and recipes-kernel,
and putting there the .bbappend files.

To add it to the same layer, I have not found any other way as to use an
include file for all general rules. So adding a u-boot-mkimage-mx28.bb,
that sets the SRC_URI and that includes u-boot-mkimage_2013.07.bb (maybe
changing the name..), and then setting a PREFERRED_PROVIDER into the
machin configuration file. But really I prefer the first solution adding
a layer for the hardware. I am curious if someone has found another
solution.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================