[ELDK] [PATCH 4/5] META-ELDK: Drop bogus concatenation

[Lothar Rubusch]

Hehe, nice one..! 

> Gesendet: Donnerstag, 19. September 2013 um 14:27 Uhr
> Von: "Marek Vasut" <marex at denx.de>
> An: eldk at lists.denx.de
> Cc: wd at denx.de, l.rubusch at gmx.ch, "Marek Vasut" <marex at denx.de>
> Betreff: [PATCH 4/5] META-ELDK: Drop bogus concatenation
>
> The EXTRA_OEMAKE should be set in this case, not appended. This fixes
> previous patch from Lothar. Note that in case the EXTRA_OEMAKE is
> appended, the build will fail.

True! But those were the days when Marek recommended Lothar to replace the '=' rather by '=+' ;o)

The old (unpublished) version looked as follows:
(...)
 41 +## native and always
 42 +#EXTRA_OEMAKE += 'CROSS_COMPILE="${TARGET_PREFIX}" HOSTCC="${CC}" HOSTLD="${LD}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
 43 +## ...but has to be native for m28evk (...)
 44 +EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}" HOSTCC="${CC}" HOSTLD="${LD}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true CONFIG_MX28=y'
(...)

Here for me, it is still interesting and a bit scary, since I definitely tested having the '+=' present, from a completely clean setup. AFAIR it worked out. Does that mean now, it "can" work out? Sometimes?? 

Anyway, initially I also experienced issues here, having a '+=', that's why I wrote a comment, as above. Since this comment did not justify WHY actually there is an issue, obviously it did not convince us, when Marek was in Munich. Perhaps it should be commented that it is actually no mistake leaving out the '+', as one is tempted to insert it, especially with a chance that this error may stay hidden.

Best,
L



> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
>  meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb b/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb
> index a4bf1ad..5491cd9 100644
> --- a/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb
> +++ b/meta-eldk/recipes-bsp/uboot/u-boot-mkimage_2013.07.bb
> @@ -20,7 +20,7 @@ S = "${WORKDIR}/git"
>  BBCLASSEXTEND = "native nativesdk"
>  
>  ## native and always
> -EXTRA_OEMAKE += ' CROSS_COMPILE="${TARGET_PREFIX}" HOSTCC="${CC}" HOSTLD="${LD}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
> +EXTRA_OEMAKE = ' CROSS_COMPILE="${TARGET_PREFIX}" HOSTCC="${CC}" HOSTLD="${LD}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
>  ## ...but has to be native for m28evk (...)
>  EXTRA_OEMAKE += ' CONFIG_MX28=y'
>  
> -- 
> 1.8.4.rc3
> 
>