[tbot] Contribution of 41 patches

Heiko Schocher hs at denx.de
Mon Oct 9 12:50:30 UTC 2017


Hello Mark,

Am 05.10.2017 um 15:12 schrieb Jonas Mark (ST-FIR/ENG1):
> Hello Heiko,
>
> I would like to contribute 41 patches to tbot. :)
>
> The patches are attached to this email. I am sorry - I am Outlook handicapped.

One comment:

> From 4ff0f8558f265cb70d0218e61676331955af489d Mon Sep 17 00:00:00 2001
> From: Constantin Schuett <fixed-term.constantin.schuett at de.bosch.com>
> Date: Thu, 13 Apr 2017 11:55:44 +0200
> Subject: [PATCH 13/41] new testcase: tc_workfd_set_gpio.py testcase for
>  controlling gpios through sysfs
[...]
> diff --git a/src/tc/linux/tc_workfd_set_gpio.py b/src/tc/linux/tc_workfd_set_gpio.py
> new file mode 100644
> index 0000000..409eab3
> --- /dev/null
> +++ b/src/tc/linux/tc_workfd_set_gpio.py
> @@ -0,0 +1,49 @@
[...]
> +if arg.get('highlow') == 'high':
> +    tb.eof_write_cmd(c, 'echo 1 > ' + gpiotemp.path + 'gpio' + gpiotemp.number + '/value')
> +
> +elif arg.get('highlow') == 'low':
> +    tb.eof_write_cmd(c, 'echo 0 > ' + gpiotemp.path + 'gpio' + gpiotemp.number + '/value')

We should handle the "else" case too, so:

log an error and end testcase false in the else case please.
Something like that:

else:
     loggin.error("%s not supported", arg.get('highlow'))
     tb.end_tc("False")

Same applies for patch:
> From 09d8bb0ecd3aa100b4d592f9128794397a289d7d Mon Sep 17 00:00:00 2001
> From: Heiko Schocher <hs at denx.de>
> Date: Mon, 28 Aug 2017 08:52:35 +0200
> Subject: [PATCH 14/41] new testcase: tc_lab_power_onoff_gpio.py

Beside of this, I am fine with this patches.

Many thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the tbot mailing list