[tbot] [DENX] tbot: board hangs if no autoload

Stefano Babic sbabic at denx.de
Fri Nov 16 12:06:03 UTC 2018


On 16/11/18 12:50, Claudius Heine wrote:
> Hi Heiko,
> 
> Quoting Heiko Schocher (2018-11-16 11:18:00)
>> Hello Claudius,
>>
>> Am 16.11.2018 um 09:08 schrieb Claudius Heine:
>>> Hi Heiko,
>>>
>>> Quoting Heiko Schocher (2018-11-15 13:01:47)
>>>>> But what developers surely need (and this is why I put functional tests
>>>>> on top of priorities) is a way to validate what they did and to have
>>>>> regression tests without a lot of effort. And in both of them, tbot excels.
>>>>
>>>> Isn;t it for example also a valid testcase to ensure, that u-boot for
>>>> example compiles?
>>>>
>>>> Just yesterday I posted a patch on U-Boot ML, which compiled, but dropped
>>>> warnings I did not check, because I build U-Boot with bitbake ... :-(
>>>
>>> Maybe a bit off-topic, but shouldn't that be solved with `-Werror`?
>>
>> Maybe there is an option in bitbake ? I do not know.
> 
> IMO that should be the default parameter upstream if that is the goal.
> 

Right.

> If the upstream project does not care about warnings, then bitbake has
> to ignore them too, if the upstream cares about them and adds 'Werror'
> to their build, then bitbake should abort the build as well.

Yes, it is so. Each project chooses which is the best way for
development, and how to track errors / warnings / and so on. For U-Boot,
Tom decided for buildman (in U-Boot) and Travis.

> 
> From what I see u-boot does not have `Werror` in its default build, so
> maybe add it?
> 
> In any case it doesn't make sense to check for compile warnings in tbot
> itself IMO.

+1

Regards,
Stefano




-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the tbot mailing list