[PATCH v10 8/9] sandbox: Update the test MAC/IP addresses

[Tom Rini]

On Sun, Oct 24, 2021 at 01:54:17PM -0600, Simon Glass wrote:
> Hi Heinrich,
> 
> On Sat, 23 Oct 2021 at 02:30, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >
> >
> >
> > On 10/22/21 05:08, Simon Glass wrote:
> > > These conflict with real-word addresses. Use locally administered
> > > MAC addresses and a suitable IPv4 address from 192.0.2.0/24
> > > (TEST-NET-1).
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > Suggested-by: Alexander Dahl <ada at thorsis.com>
> > > ---
> > >
> > > Changes in v10:
> > > - Add new patch to update the test MAC/IP addresses
> > >
> > >   board/sandbox/sandbox.env | 14 +++++++-------
> > >   1 file changed, 7 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/board/sandbox/sandbox.env b/board/sandbox/sandbox.env
> > > index 0f8d95b8db0..b4c04635a48 100644
> > > --- a/board/sandbox/sandbox.env
> > > +++ b/board/sandbox/sandbox.env
> > > @@ -5,13 +5,13 @@ stdin+=,cros-ec-keyb,usbkbd
> > >   stdout=serial,vidconsole
> > >   stderr=serial,vidconsole
> > >
> > > -ethaddr=00:00:11:22:33:44
> > > -eth2addr=00:00:11:22:33:48
> > > -eth3addr=00:00:11:22:33:45
> > > -eth4addr=00:00:11:22:33:48
> > > -eth5addr=00:00:11:22:33:46
> > > -eth6addr=00:00:11:22:33:47
> > > -ipaddr=1.2.3.4
> > > +ethaddr=02:00:11:22:33:44
> > > +eth2addr=02:00:11:22:33:48
> > > +eth3addr=02:00:11:22:33:45
> > > +eth4addr=02:00:11:22:33:48
> >
> > Ethernet addresses should be unique.
> >
> > Should it be on purpose that two Ethernet address are the same, please
> > add a comment in the code.
> 
> Can you please explain what you are getting out here? Which ones are not unique?

I think you made a mistake ages ago by not doing eth..eth6 in sequence
and updating the last digit each time.  Before and after eth2addr and
eth4addr both end in 48.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot-board-maintainers/attachments/20211024/375a46b7/attachment.sig>