[U-Boot-Users] Re: Patch for U-Boot 0.1.1: sbc8260 configuration tweaks

[Wolfgang Denk]

Dear Jon,

in message <200211100411.XAA19783 at lucky.si.com> you wrote:
> 
> sbc8260 configuration tweaks:

Ummm... partially added, and in a modified form.

I wish you  had  negotiated  your  changes  with  Oliver  Brown  (the
official maintainer of the SBC8260 board) first.

> - The image timestamp support and the alternate memory test were activated.

Added.

> - The extra env setttings were flushed out.

Added partially.

> - The boot delay was reduced from 5 to 3 seconds

_NOT_ added.

> - The default load address was increased from 0x140000 to 0x400000

Added.


Some comments;


> --- include/configs/sbc8260.h	3 Nov 2002 00:57:12 -0000	1.1.1.1
> +++ include/configs/sbc8260.h	10 Nov 2002 02:34:25 -0000
> @@ -241,7 +241,7 @@
>  /*
>   * select SPI support configuration
>   */
> -#undef  CONFIG_SPI			/* enable SPI driver		*/
> +#undef  CONFIG_SPI			/* Enable SPI driver */


Both versions look nonsense to me.

> +/* Define this to contain any number of null terminated strings that
> + * will be part of the default enviroment compiled into the boot image. 
> + */
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> +"serverip=192.168.123.201\0" \
> +"ipaddr=192.168.123.203\0" \
...

I wish you had checked this with the board maintainer first! Oliver,
is this OK for you?

> +"root-on-initrd="\
> +    "setenv bootcmd "\
> +    "version\\;" \
> +    "echo\\;" \
> +    "bootp\\;" \
> +    "setenv bootargs root=/dev/ram0 rw " \
> +    "ip=\\$(ipaddr):\\$(serverip):\\$(gatewayip):\\$(netmask):\\$(hostname)::off\\;" \
> +    "run boot-hook\\;" \
...

Changed. I guess you did not test this? It probably does not do  what
you intend to do, or I may be wrong. Please check the ckecked in code
if it works as intended.

>  /* Ethernet MAC address */
> -#define CONFIG_ETHADDR		00:a0:1e:a8:7b:cb
> +#define CONFIG_ETHADDR		00:a0:1e:a8:7b:aa

NOT accepted, as it will probbaly break Oliver's board; I don't  like
such stuff, but he is the board's maintainer, so he decides.

>  /* Set to a positive value to delay for running BOOTCOMMAND */
> -#define CONFIG_BOOTDELAY	5	/* autoboot after 5 seconds */
> +#define CONFIG_BOOTDELAY	3	/* autoboot after 3 seconds */

Same.

> -#if 0
>  /* Be selective on what keys can delay or stop the autoboot process
>   *     To stop	use: " "
>   */
> -# define CONFIG_AUTOBOOT_KEYED
> -# define CONFIG_AUTOBOOT_PROMPT "Autobooting in %d seconds, press \" \" to stop\n"
> -# define CONFIG_AUTOBOOT_STOP_STR	" "
> -# undef CONFIG_AUTOBOOT_DELAY_STR
> -# define DEBUG_BOOTKEYS		0
> -#endif
> +#define CONFIG_AUTOBOOT_KEYED
> +#define CONFIG_AUTOBOOT_PROMPT "\nAutobooting in %d seconds, press \" \" to stop\n"
> +#define CONFIG_AUTOBOOT_STOP_STR	" "
> +#undef  CONFIG_AUTOBOOT_DELAY_STR
> +#define DEBUG_BOOTKEYS		0
>  
>  /* Define a command string that is automatically executed when no character
>   * is read on the console interface withing "Boot Delay" after reset.

Same.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
See us @ electronica 2002 in Munich, Nov 12-15, Hall A3, Booth A3.325