[U-Boot-Users] [PATCH] changes to IDE driver for LSB machines
wd at denx.de
Thu Aug 14 21:54:41 CEST 2003
In message <20030814183104.GA23820 at buici.com> you wrote:
> Aside from the ARM additions, there are changes to allow the IDE code
> to run on other little endian machines IA32, mips.
> BTW, the macro names, WORDS_BIGENDIAN and BYTES_BIGENDIAN come from
Maybe. But we don't use autoconf in U-Boot. I don;t like to invent
new macro names if there is a working mechanism in place already.
Please use <include/asm/byteorder.h>".
> Also, the endianness of mips isn't clear. Like PPC, it can do either
> and as far as I can tell both are supported by Debian.
This is why I do not want to base such stuff on the name of the
architecture. There is a generic way to solve this issue, so please
let's use this.
> +* Patch by Marc Singer, 14 Aug 2003
> + - New target, Sharp KEV7A400
> + - New configuration method using mkconfigx script
> + - IDE drivers changes to support little endian CPUs.
Please separate the new board support from the changes to the IDE
BTW: I don't see any new board support stuff in this patch???
> +input_data(int dev, ulong *sect_buf, int words)
> + volatile u32* p = (volatile void*)(ATA_CURR_BASE (dev));
> + u16* rg = (void*) sect_buf;
> + while (words--)
> + *rg++ = (*p)&0xffff;
> + // insw(ATA_DATA_REG, sect_buf, words << 1);
Please don't use C++ comments.
> - int start,end;
> +#if !defined (BYTES_BIGENDIAN) || defined (__PPC__)
I quote yourself::
"Also, the endianness of mips isn't clear. Like PPC, it can
And here you base an assumption on the architecture name? Please
decide what you want.
And below you add BYTES_BIGENDIAN for PPC systems, so this makes
really little sense to me.
> PLATFORM_CPPFLAGS += -DCONFIG_PPC -D__powerpc__
> PLATFORM_LDFLAGS += -n
> +PLATFORM_CPPFLAGS += -DWORDS_BIGENDIAN -DBYTES_BIGENDIAN
This just pollutes the namespace and is 100% redundand. Please use
the existent macros.
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
By the way, ALL software projects are done by iterative prototyping.
Some companies call their prototypes "releases", that's all.
More information about the U-Boot