[U-Boot-Users] [PATCH] ARM925/OMAP updates and console device chaining.
Woodruff, Richard
r-woodruff2 at ti.com
Sat Aug 30 00:14:31 CEST 2003
Hi Wolfgang,
I was hoping to get comments on the device chaining aspect. I put this
together quickly with that more central in my mind. So ...? (later I did
notice that there were 4 c++ comments in there also).
I can break up the 925/omap bits. I have a couple critical fixes to add
anyway.
Best Regards,
Richard Woodruff
> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Friday, August 29, 2003 5:07 PM
> To: Woodruff, Richard
> Cc: 'u-boot-users at lists.sourceforge.net'
> Subject: Re: [U-Boot-Users] [PATCH] ARM925/OMAP updates and
> console device chaining.
>
>
> In message
> <FD2AC9A020DDD51194710008C7089B200BEE2301 at dlee17.itg.ti.com>
> you wrote:
> >
> > This patch adds a few updates for the ARM925/OMAP boards.
> > - DSP idle routine (I call from board specific code).
> > - cache flush implemented so lib_arm/cache.c is not just a place
> > holder.
> > - header file updates.
> > It also adds support for having multiple devices called as
> part of your
> > console (if you install them). There is also a handy
> CCACHE addition to the
> > makefile which can speed up compilations a if you have
> ccache on your
> > machine. ... I have also included the nand fix which I
> submitted a little
> > while ago.
>
> Please split into separate (orthogonal) parts.
>
> Please make extensions (multiple device support) configurable.
>
> Also:
>
> Please do not use C++ comments.
>
> Please use proper indentation (TABs).
>
> Please do not add trailing white space.
>
> Please exclude the ccache part, as this tool is not
> commonly available.
>
>
> Patch rejected.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> Software Engineering: Embedded and Realtime Systems, Embedded Linux
> Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
> "A witty saying proves nothing." - Voltaire
>
More information about the U-Boot
mailing list