[U-Boot-Users] [PATCH] PCMCIA card support for PXA/WEPEP250

[Wolfgang Denk]

Dear Leon,

in message <Pine.CYG.4.55.0311201012400.1212 at sniper.ultra.si> you wrote:
> 
> Note that I have changed TEXT_ADDRESS for WEPEP250 board to start at
> 0xA1000000. If my understanding is correct, Linux kernel will use the memory
> that was occupied by U-Boot code while running in RAM. Tweaking can be done
> later.

Why do you think such a change (which does waste memory while running
U-Boot) is necessary?

> In case of any issues, let me know.

* Please do not add trailing white space to your source files.

* Please do not use names like "convert_string_in_big_endian_to_little_endian()";
  such code is impossible to read.

* I don't want to see code like "convert_string_in_big_endian_to_little_endian()"
  in common/cmd_ide.c

* The implementation of "convert_string_in_big_endian_to_little_endian()"
  seems broken to me. The use of two_byte_p and complicated shift ops
  is not necessary when simple operations of character pointers  will
  do,  too.  Also,  using  a  "ushort *" might cause problems on some
  boards when the string buffer is not alligned to an even address.

* "#if defined(__LITTLE_ENDIAN) && defined(CONFIG_WEPEP250)"  -  this
  code seems broken to me. Either this is something that is necessary
  on  all  little-endian  systems, or only for the WEPEP250 board, or
  for all boards using this processor.

* I see no good reason to include cpu/pxa/generic.c - if  you  really
  want  to  use  get_lclk_frequency_10khz()  you can copy this single
  source line; otherwise please clean up cpu/pxa/generic.c - the  use
  of "printk()" etc. is not acceptable.

* You add/modify a number of architecture specific header  files  and
  some  source  files.  Can you guarantee that these modifications do
  not break support for other ARM boards? Are all these modifications
  really needed? To me it seems  only  a  small  subset  is  actually
  necessary.  I  don't  want  to  blow  up U-Boot if we can avoid it.
  Please clean up to use only the really necessary stuff.


Patch rejected. Please clean up and resubmit.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
The inappropriate cannot be beautiful.
             - Frank Lloyd Wright _The Future of Architecture_ (1953)