[U-Boot-Users] Re: probably bug in ds1621.c

[Wolfgang Denk]

Hello,

in message <3812591505.20030702114201 at morion.ru> you wrote:
> 
> In dtt/ds1621.c file:
> 
> 1.
> int dtt_write(int sensor, int reg, int val)
> {
>     int dlen;
>     uchar data[2];
> 
>     /*
>      * Calculate sensor address and register.
>      *
>      */
>     sensor = DTT_I2C_DEV_CODE + (sensor & sensor);
> 
> I think it should be:
> 
> int dtt_write(int sensor, int reg, int val)
> {
>     int dlen;
>     uchar data[2];
> 
>     /*
>      * Calculate sensor address and register.
>      *
>      */
>     sensor = DTT_I2C_DEV_CODE + (sensor & 0x07);


I think you are right. Added.


> 2.
>     else if ((reg == DTT_WRITE_START_CONV) || (reg == DTT_WRITE_STOP_CONV)) {
>         dlen = 0;
>         data[0] = (char)0;
>         data[1] = (char)0;
>     }
> 
> I think it should be:
> 
>     else if ((reg == DTT_WRITE_START_CONV) || (reg == DTT_WRITE_STOP_CONV)) {
>         dlen = 1;
>         data[0] = (char)0;
>         data[1] = (char)0;
>     }
> 
> differently MPC8260 I2C controller go in down

I'm not sure about this one. Erik, maybe you can comment?  It's  your
code after all...

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
The day-to-day travails of the IBM programmer are so amusing to  most
of us who are fortunate enough never to have been one - like watching
Charlie Chaplin trying to cook a shoe.