[U-Boot-Users] [PATCH] DataFlash for AT91RM9200DK board
wd at denx.de
Tue Jun 3 18:56:58 CEST 2003
in message <031601c329e5$0c9fba70$91f59f0a at pc0752> you wrote:
> Find attached a patch applied against the 0.3.0 release.
> It implements several changes for Atmel AT91RM9200DK development kit.
> - Add Atmel DataFlash support for reading and writing (new entry CFG_CMD_=
> DATAFLASH in cmd_confdefs.h file)
Why do we need a special command to access the DataFlash? I would
like to see the same interface as for all other flash devices.
Also, why did you place drivers/at45.c in the (common) drivers/
directory? It seems to be very CPU-specific code to me?
Thinking twice, the same is true for drivers/at91rm9200_ether.c: this
code should IMHO go to a CPU dependend directory, but not to the
common drivers/ directory.
> - Add Flash detection between AT49BV1614 and AT49BV1614A flashes.
Your flash protection mechanism seems to be based on some #define'd
CFG_* parameters; please check our changes in the current CVS version
to get rid of such constants (like CFG_MON_LEN). Maybe you want to
adjust your code?
> - Replace old Ethernet PHY configuration functions
> - New link address
Some files (drivers/at91rm9200_ether.c,
include/asm-arm/arch-at91rm9200/AT91RM9200.h, include/dataflash.h) do
not contain GPL headers and/or copyright notices. Can you please add
/ fix these?
And please remove all C++ style comments (//), and trailing white
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
There is an order of things in this universe.
-- Apollo, "Who Mourns for Adonais?" stardate 3468.1
More information about the U-Boot