[U-Boot-Users] Re: [PATCH] 2/4: bootz command

[Wolfgang Denk]

In message <200306200925.01556.h.schurig at mn-logistik.de> you wrote:
> > > +    ulong addr = 0x40000;
> > Please do not use any magic hardwired constants.
> > Can we use existent logic again, i. e. load_addr ?
> 
> You can blame me for this. I did not run over load_addr so far.

I don;t blame anybody for  anything.  My  only  interest  is  to  get
working code.

> > Did this really compile for any PowerPC or MIPS board?
> 
> No idea. I will not go and install various cross-compilers for board I don't 
> have and where I don't even have the URL for the cross-compiler to download 

You  can  download  the  ELDK  (for  ARM,  PowerPC  and  MIPS)   from
ftp://ftp.leo.org/pub/eldk/

> from. For now, it's an arm-only patch as long as no one from the 
> PPC/MIPS/Whatever community needs it.

Robert submitted it as a standard  patch,  hooking  into  the  common
command  code,  without  any  indication that this might be ARM only.
Also, there is no need to make this  ARM  only  -  I  don't  see  any
inherent dependency on the platform.

> After all, there is already arm-only code in u-boot, e.g. the code from 
> arm_lib/* that I used.

But this is a different issue.

> > On  PowerPC,  there  is  neither  a  header  file   "tag.h"   nor   a
> > cleanup_before_linux() function...
> 
> The tag.h is a file that I made. Wasn't it part of my original patch?

I am not aware of your original patch. I just know what Robert sent.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Human beings were created by water to transport it uphill.