[U-Boot-Users] Re: [PATCH]: Enable device and console for ARM (III).

Wolfgang Denk wd at denx.de
Sun Jun 22 18:37:13 CEST 2003

Dear Richard,

in message <FD2AC9A020DDD51194710008C7089B20053D4C99 at dlee17.itg.ti.com> you wrote:
> Here is the patch re-submitted removing the movement of the trab specific
> code.  I just rebuilt it and tried it out on my board and it works.  No
> surprise as I don't have anything trab specific.
> The trab not working still surprises me, hopefully this change will fix it.

The TRAB is a bit special, for example as you can switch  to  console
interface to a dial out/dial in modem connection, which requires some

> Getting the console working is a GOOD thing for ARM.  Being able to use
> control^c and enabling a clean stdin/out/err is something which should be
> made to work.  

You are right.

> The patch is as before, enables device and console on ARM and sets the
> baudrate such that bdinfo prints something reasonable.

Thanks. Added.

A few requests though for your next patch:

* Please stick to the coding standards (i.  e.  8  character  indents
  using tab characters).
* Do not add trailing white space to the lines
* Make sure to run the  MAKEALL  script,  and  resolve  ALL  compiler
  warnings introduced by your patch.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Genius doesn't work on an assembly line basis.  You can't simply say,
"Today I will be brilliant."
	-- Kirk, "The Ultimate Computer", stardate 4731.3

More information about the U-Boot mailing list