[U-Boot-Users] [PATCH] 6/9: i2c_init_board

[Wolfgang Denk]

In message <20030306123527.GS16290 at pengutronix.de> you wrote:
> 
> - introduced a new i2c_init_board() function, to be implemented by the
>   board maintainers for boards that support it.
...
> +		CFG_I2C_INIT_BOARD
> +
> +		When a board is resetted during an i2c bus transfer chips

<fascist mode>
See your 7th grade English book if you don't know that it's
reset|reset|reset.
</fascist mode>

Dear Robert, as you can see, nobody is  perfect.  Not  even  you.  So
please save your malicious comments.


> +		directly, either by using the processor pin as a GPIO or 
> +		by having a second pin connected to the bus. If this option
> +		is defined a custom i2c_coldstart() routine in 
> +		boards/xxx/board.c is run early in the boot sequence. 

Also, the comment seems to be wrong.

> --- u-boot/cpu/mpc8260/i2c.c	2002-11-03 01:31:58.000000000 +0100
> +++ u-boot-ptx/cpu/mpc8260/i2c.c	2003-03-06 10:41:59.000000000 +0100


...


Did you just miss it, or is there any special reason not to add this to
cpu/mpc824x/drivers/i2c/i2c1.c , too?



Added.




Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
The high cost of living hasn't affected its popularity.