[U-Boot-Users] [PATCH] 5/5: progress

Wolfgang Denk wd at denx.de
Mon Mar 31 12:17:06 CEST 2003


In message <20030331093502.GP7702 at pengutronix.de> you wrote:
> 
> - fix BOOT_PROGRESS in armlinux.c
> - cosmetic changes (must be allowed as I've touched the file anyway :^)

Nothing "must" be allowed. I even allow myself to change my own
opinion ;-)


> @@ -88,7 +95,6 @@
>       */
>      if (argc >= 3) {
>  	SHOW_BOOT_PROGRESS (9);
> -
>  	addr = simple_strtoul(argv[2], NULL, 16);
>  
>  	printf ("## Loading Ramdisk Image at %08lx ...\n", addr);

Willignore this change.

> @@ -98,7 +104,7 @@
>  
>  	if (ntohl(hdr->ih_magic) != IH_MAGIC) {
>  	    printf ("Bad Magic Number\n");
> -	    SHOW_BOOT_PROGRESS (-10);
> +            SHOW_BOOT_PROGRESS (-10);
>  	    do_reset (cmdtp, flag, argc, argv);
>  	}

I will ignore this one, too.

> @@ -235,7 +235,7 @@
>  static void setup_start_tag(bd_t *bd)
>  {
>      params = (struct tag *)bd->bi_boot_params;
> -
> +    
>      params->hdr.tag = ATAG_CORE;
>      params->hdr.size = tag_size(tag_core);

And, as I have told you about 10  times  before,  I  will  definitely
ignore all patches that add trailing white space.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Well, the way I see it, logic is only a way of being ignorant by num-
bers.                                 - Terry Pratchett, _Small Gods_




More information about the U-Boot mailing list