[U-Boot-Users] [PATCH] 1/5: cmd_boot

Robert Schwebel r.schwebel at pengutronix.de
Mon Mar 31 16:16:07 CEST 2003


On Mon, Mar 31, 2003 at 04:03:45PM +0200, Wolfgang Denk wrote:
> Ummm... YMMV, but IMHO a working  tool  is  _always_  better  than  a
> broken one, no matter which user interface it has.

Above you stated that you don't know if minicom is broken or if it has
another reason. 

> > People use it, so it should be supported. Other question: does my patch
> > do any harm to your ckermit? If not, what's the problem? 
> 
> Code size. Yes, even these few bytes.

Wolfgang, the code has been in that file for ages. The only thing I did
is to move it to the right location, which is _before_ the printf() in
load_serial_bin(), not _after_ the function returned. Please explain why
moving code changes the binary size. 

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Braunschweiger Str. 79,  31134 Hildesheim, Germany
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4




More information about the U-Boot mailing list