[U-Boot-Users] PCI patch for MPC8266

[Wolfgang Denk]

Dear Rune,

in message <9F5558593173D21190EA0008C7B1769873136E at innsys1> you wrote:
> 
> Patch for getting PCI to work on a MPC8266ADS board.
> 
> Also incorporates change to /cpu/mpc8260/pci.c to enable overrides of PCI
> memory parameters


Ummm... please: when you submit a patch next time please make sure to
run a "make mrproper" first. You patch contained about 90% of garbage
(patches for irrelevant ".depend" or "include/config.h" files etc.).


I added most of this to our local tree and will push it to public CVS
later.


diff -purN u-boot-0.3.0/common/cmd_bootm.c u-boot-0.3.0_pci/common/cmd_bootm.c
--- u-boot-0.3.0/common/cmd_bootm.c	2003-05-12 17:33:37.000000000 -0400
+++ u-boot-0.3.0_pci/common/cmd_bootm.c	2003-05-12 17:03:15.000000000 -0400
@@ -426,6 +426,16 @@ do_bootm_linux (cmd_tbl_t *cmdtp, int fl
 		kbd->bi_vco     /= 1000000L;
 #endif /* CONFIG_8260 */
 	}
+		printf("Passing Clocks as:\n");
+		printf("kbd->bi_intfreq = %ld\n", kbd->bi_intfreq);
+		printf("kbd->bi_busfreq = %ld\n", kbd->bi_busfreq);
+#if defined(CONFIG_8260)
+		printf("kbd->bi_cpmfreq = %ld\n", kbd->bi_cpmfreq);
+		printf("kbd->bi_brgfreq = %ld\n", kbd->bi_brgfreq);
+		printf("kbd->bi_sccfreq = %ld\n", kbd->bi_sccfreq);
+		printf("kbd->bi_vco = %ld\n", kbd->bi_vco);
+#endif /* CONFIG_8260 */
+	
 
 	kernel = (void (*)(bd_t *, ulong, ulong, ulong, ulong))hdr->ih_ep;
 

Rejected. This is debug code at best.



diff -purN u-boot-0.3.0/cpu/mpc8260/cpu.c u-boot-0.3.0_pci/cpu/mpc8260/cpu.c
--- u-boot-0.3.0/cpu/mpc8260/cpu.c	2003-05-12 17:33:38.000000000 -0400
+++ u-boot-0.3.0_pci/cpu/mpc8260/cpu.c	2003-05-12 17:03:16.000000000 -0400
@@ -64,7 +64,8 @@ int checkcpu (void)
 	if ((immr & IMMR_ISB_MSK) != CFG_IMMR)
 		return -1;	/* whoops! someone moved the IMMR */
 
-	printf ("MPC8260 (Rev %02x, Mask ", rev);
+	printf ("%s (Rev %02x, Mask ", 
+		((pvr >> 16) == 0x0081) ? "MPC8260" : "MPC8266", rev);
 
 	/*
 	 * the bottom 16 bits of the immr are the Part Number and Mask Number

Rejected. The code is wrong. MPC8260 mask rev. 0.2 would have  0x0091
in  the PVR; so far I did not find a full table allowing to determine
the chip type (MPC8250, MPC8255, MPC8260, MPC8264, MPC8265,  MPC8266)
from the PVR alone.



Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Every program has at least one bug and can be shortened by  at  least
one instruction - from which, by induction, one can deduce that every
program can be reduced to one instruction which doesn't work.