[U-Boot-Users] JFFS2 speed enhancement patch

Wolfgang Denk wd at denx.de
Sun Apr 25 17:39:13 CEST 2004

In message <20040423155233.C8298 at gateway.bln.innominate.local> you wrote:
> for the sake of speed I repaired the header CRC calculation
> in the jffs2_1pass.c.
> I also added the eraseblock size to the partition information
> to skip empty eraseblocks if we find more then 4k of free space.

Note that your patch  breaks  all  boards  which  use  JFFS2  without
defining PHYS_FLASH_SECT_SIZE - I guess you forgot to run the MAKEALL
script? Grrrgh...

Actually, PHYS_FLASH_SECT_SIZE is just a private definition used  in-
ternally  by  some boards; it is definitely NOT a configuration para-
meter which can be used in common code.

I will back out your patch, and reject it.

Please clean it up, amd make sure to use only public data.

Also, please don't forget to run  MAKEALL  to  make  sure  the  other
boards are at least compile clean.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
A good marriage would be between a blind wife and deaf husband.
                                               -- Michel de Montaigne

More information about the U-Boot mailing list