[U-Boot-Users] [PATCH] Generic Support for Motorola i.MX architecture

[Wolfgang Denk]

Dear Sasha,

in message <20040628120334.GA27672 at herry.saufen> you wrote:
> 
> I removed the trailing white spaces, dos line endings, etc from the
> patch. Ming-Len Wu sent me a patch for mx1ads boards, which I included
> into the patch. I can't test mx1ads support, but he says it works.
> 
> You can download the patch here:
> 
> http://www.pengutronix.de/software/u-boot/u-boot-imx1-20040628-1.diff

Added, thanks.

I understand that this patch obsoletes all your previous patches,
i. e. the following messages:

06/17 Sascha Hauer       [U-Boot-Users] [PATCH] Motorola i.MX support (1/2)<<--HlL+5n6rz5pIUxb
06/17 Sascha Hauer       [U-Boot-Users] [PATCH] Motorola i.MX support (2/2)<<--cmJC7u66zC7hs+8
06/18 Sascha Hauer       Re: [U-Boot-Users] [PATCH] Motorola i.MX support (1/2)<<I've just had
06/19 Robert Schwebel    Re: [U-Boot-Users] [PATCH] Motorola i.MX support (1/2)<<Hi, On Fri, J
06/19 Sascha Hauer       Re: [U-Boot-Users] [PATCH] Motorola i.MX support (1/2)<<On Sat, Jun 1
06/21 Robert Schwebel    Re: [U-Boot-Users] [PATCH] Motorola i.MX support (1/2)<<--SO98HVl1bnM
06/21 Steven Scholz      Re: [U-Boot-Users] [PATCH] Motorola i.MX support (1/2)<<Robert Schweb
06/21 Robert Schwebel    Re: [U-Boot-Users] [PATCH] Motorola i.MX support (1/2)<<On Mon, Jun 2

Please confirm.


Technical problems:

* In include/configs/mx1ads.h etc. you have this:

  #define        CFG_HZ                  3686400

  This is BROKEN. CFG_HZ is the number of timer ticks per second.
  You don't want to process more than 3 millions of interrupts per sec.
  Please don't mis-use CFG_HZ for things it was not intended for.


Formal problems:

* Entries for MAKEALL and MAINTAINERS missing. Please submit new patch!

* Would you please keep lists sorted, i.  e.  don't  mix  ARM  boards
  inbetween PowerPC systems, and sort the names in ascending order?

* Please use plain '#' comments in Makefiles etc. Your
	#/*
	#*
	...
	#*
	#*/
  is ugly.

* Please do not add trailing white space
  (board/mx1fs2/memsetup.S, include/configs/mx1ads.h)

* Please do not add trailing empty lines.

* Please don't modify a file if all you change  is deleting an empty line.

* Don't use 3 or more consecutive empty lines.

* Please don't include opject files multiple times (cpu.o in
  cpu/arm920t/Makefile)


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
He who hesitates is not only lost, but miles from the next exit.