[U-Boot-Users] [PATCH] Remove static network setup defaults from mx1ads_config

[George G. Davis]

Greetings,

I have this pet peeve about including local network setup details in target
config files. These details should not be hard coded in target config files.
They should either be manually enterred at the u-boot command line prompt or
obtained via bootp/dhcp. This patch removes local network settings from the
mx1ads config file. Also, N.B., that you need to provide your own target
unique MAC address (setenv ethaddr) because the MX1ADS board vendor did not
provide one for you (shame on them : ). Again, it's a bad idea to hard code
ethaddr in the default board config for many reasons. Meanwhile it's trivial
to do `setenv ethaddr` and shoot yourself in the foot but then at least you're
pulling the trigger yourself.

--
Regards,
George
-------------- next part --------------
* Patch by George G. Davis, 24 Aug 2004:
  - Remove static network setup defaults from mx1ads_config.

-------------- next part --------------
Index: u-boot/include/configs/mx1ads.h
===================================================================
RCS file: /cvsroot/u-boot/u-boot/include/configs/mx1ads.h,v
retrieving revision 1.3
diff -u -r1.3 mx1ads.h
--- u-boot/include/configs/mx1ads.h	1 Aug 2004 22:48:22 -0000	1.3
+++ u-boot/include/configs/mx1ads.h	24 Aug 2004 17:04:28 -0000
@@ -99,10 +99,6 @@
 
 #define CONFIG_BOOTDELAY	3
 #define CONFIG_BOOTARGS		"root=/dev/msdk mem=48M"
-#define CONFIG_ETHADDR		08:00:3e:26:0a:5c
-#define CONFIG_NETMASK		255.255.255.0
-#define CONFIG_IPADDR		192.168.0.22
-#define CONFIG_SERVERIP		192.168.0.11
 #define CONFIG_BOOTFILE		"mx1ads"
 #define CONFIG_BOOTCOMMAND	"tftp; bootm"