[U-Boot-Users] u-boot.h/bd_t missing fields needed by Linux IBM IIC I2C Interface Driver

[listmember at orkun.us]

Brian,

I would like to submit the changes but now there is a conflict because one
field in board info structure that is named different.

The one in linuxppc tree uses bi_opb_busfreq while DENX tree uses
bi_opbfreq. This affects one line in linuxppc tree's i2c-ibm_iic.c.

If I were to patch the i2c-ibm_iic.c on linuxppc tree I would break others
that had the field other way (thus I would need to patch all other
platforms as well). If I just patch the ppcboot.h in linuxppc tree than I
would create inconsistency between DENX and linuxppc trees as well as the
u-boot.h.

So, I am not sure what is the best way to handle it. I do not know why the
field name diverged between the two trees. I am looking for a solution
that is acceptable for everyone and also consistent of u-boot.h

I believe Wolfgang is most qualified to advise on this situation...

Best regards,
Tolunay

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Tolunay,
> 	May I suggest that after you are done testing the kernel changes that you
> post a patch for inclusion to the linuxppc-2.4 tree onto the ppc dev
> mailing
> list. I agree the number of PPC trees, and their, relevance on a given day
> is
> hard to follow, but hopefully the linuxppc-2.4 tree can stay for a while.
> The
> only way to get changes into this tree though is for someone to test and
> incorporate them. It is tough, I know. I am still trying to get things
> into
> the 2.4 kernel, but that is the way of the kernel. If no one puts a little
> sweat to get it included, then it will never get included. Just my 2 cents
> Thanks
> Brian
> On Tuesday 03 February 2004 09:12 pm, listmember at orkun.us wrote:
>> > In message <13382.24.206.119.24.1075829319.squirrel at www.orkun.us> you
>> >
>> > wrote:
>> >> > No, the  fields  are  useful  and  needed.  We  added  these  to
>> our
>> >> > "linuxppc_2_4_devel" tree some time ago:
>> >>
>> >> linuxppc_2_4_devel did not have csb272 support. According to Dan
>> Kegel
>> >> who
>> >> did the porting linuxppc_2_4_devel tree is dead and and not
>> maintained
>> >> and
>> >> changes should go to linuxppc-2.4 instead. Also the above URL
>> indicates
>> >> linux_2_4_devel is old.
>> >
>> > Well, feel free to ignore it, then. All I was trying to do is showing
>> > you where you can find a  (tested  and  working)  solution  for  your
>> > problem. Feel free to use the "new" and "living" linuxppc-2.4 source
>> tree
>> > which does not contain the fixes you need.
>>
>> No, I was not implying anything or trying to be rude. I just reported
>> what
>> I was told and initially though I should use linuxppc_2_4_devel from
>> linuxppc trees. It is a pity that all this stuff is scattered all around
>> each having bits and pieces I need but none is complete (to build CSB272
>> kernel) :(
>>
>> >> Where can I get these changes? Is this your copy of
>> linuxppc_2_4_devel
>> >> or
>> >> (so-called) official tree?
>> >
>> > As I wrote before: this is in the "linuxppc_2_4_devel" module on  our
>> > CVS server.
>>
>> Sorry, it was not clear to me. Anyway, I copied ppcboot.h and
>> i2c-ibm_iic.c (due to different field name - one line change) from your
>> tree to the linuxppc tree and it worked. However, the new fields were
>> not
>> intialized properly so driver somehow defaulted to sane values :) I am
>> using u-boot 1.0 . I guess I need to checkout u-boot from CVS and apply
>> my
>> csb272 board changes to have them initialized properly. right?
>>
>> Best regards,
>> Tolunay
>>
>>
>> -------------------------------------------------------
>> The SF.Net email is sponsored by EclipseCon 2004
>> Premiere Conference on Open Tools Development and Integration
>> See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
>> http://www.eclipsecon.org/osdn
>> _______________________________________________
>> U-Boot-Users mailing list
>> U-Boot-Users at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/u-boot-users
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.7 (GNU/Linux)
>
> iD8DBQFAINw0mxLCz0u+Ko8RAiHGAJ4qaDYryRe3KwKQhPAlfiHsjjRwNgCfQ8TO
> Q+tmx2/lPU82LKYWpWXIibU=
> =/8y1
> -----END PGP SIGNATURE-----
>
>
> -------------------------------------------------------
> The SF.Net email is sponsored by EclipseCon 2004
> Premiere Conference on Open Tools Development and Integration
> See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
> http://www.eclipsecon.org/osdn
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>