[U-Boot-Users] Incorrect flash ids?

[listmember at orkun.us]

Taken from include/flash.c...

#define INTEL_ID_28F128J3   0x89189818  /*  16M = 8M x 16 x 128 */
#define INTEL_ID_28F320J5   0x00140014  /*  32M = 128K x  32    */
#define INTEL_ID_28F640J5   0x00150015  /*  64M = 128K x  64    */
#define INTEL_ID_28F320J3A  0x00160016  /*  32M = 128K x  32    */
#define INTEL_ID_28F640J3A  0x00170017  /*  64M = 128K x  64    */
#define INTEL_ID_28F128J3A  0x00180018  /* 128M = 128K x 128    */

If I understand correctly, it seems to me that these definitions are
incorrect.  I think correct definitions should be as follows:

#define INTEL_ID_28F128J3   0x89188918  /*  16M = 8M x 16 x 128 */
#define INTEL_ID_28F320J5   0x89148914  /*  32M = 128K x  32    */
#define INTEL_ID_28F640J5   0x89158915  /*  64M = 128K x  64    */
#define INTEL_ID_28F320J3A  0x89168916  /*  32M = 128K x  32    */
#define INTEL_ID_28F640J3A  0x89178917  /*  64M = 128K x  64    */
#define INTEL_ID_28F128J3A  0x89188918  /* 128M = 128K x 128    */
#define INTEL_ID_28F256L18T 0x880D880D  /* 256M = 128K x 255 + 32k x 4 */

Please note that INTEL_ID_28F128J3 also changed (0x89189818 =>
0x89188918). I think 8 and 9 changed places due to a typo.

Best regards,
Tolunay

Here is the patch:

--- u-boot-1.0.0/include/flash.h        2003-08-29 17:00:48.000000000 -0500
+++ u-boot/include/flash.h      2004-01-12 18:14:33.061103106 -0600
@@ -207,12 +207,12 @@ extern int flash_real_protect(flash_info
 #define INTEL_ID_28F640C3T  0x88CC88CC /*  64M = 4M x 16 top boot sector 
     */
 #define INTEL_ID_28F640C3B  0x88CD88CD /*  64M = 4M x 16 bottom boot
sector    */

-#define INTEL_ID_28F128J3   0x89189818 /*  16M = 8M x 16 x 128 */
-#define INTEL_ID_28F320J5   0x00140014 /*  32M = 128K x  32    */
-#define INTEL_ID_28F640J5   0x00150015 /*  64M = 128K x  64    */
-#define INTEL_ID_28F320J3A  0x00160016 /*  32M = 128K x  32    */
-#define INTEL_ID_28F640J3A  0x00170017 /*  64M = 128K x  64    */
-#define INTEL_ID_28F128J3A  0x00180018 /* 128M = 128K x 128    */
+#define INTEL_ID_28F128J3   0x89188918 /*  16M = 8M x 16 x 128 */
+#define INTEL_ID_28F320J5   0x89148914 /*  32M = 128K x  32    */
+#define INTEL_ID_28F640J5   0x89158915 /*  64M = 128K x  64    */
+#define INTEL_ID_28F320J3A  0x89168916 /*  32M = 128K x  32    */
+#define INTEL_ID_28F640J3A  0x89178917 /*  64M = 128K x  64    */
+#define INTEL_ID_28F128J3A  0x89188918 /* 128M = 128K x 128    */
 #define INTEL_ID_28F256L18T 0x880D880D /* 256M = 128K x 255 + 32k x 4 */

 #define INTEL_ID_28F160S3   0x00D000D0 /*  16M = 512K x  32 (64kB x 32)  
     */