[U-Boot-Users] [PATCH] fix the ARM memory layout

[Anders Larsen]

"Woodruff, Richard" <r-woodruff2 at ti.com> schreibt:
>One other comment... I have some test code which does a crc32 over the rom
>portion of u-boot to help validate the image, this code used armboot_end.
>In your patch you removed that symbol.  Bss_start seems to be an "almost"
>proper substitution.  I say almost as an ALIGN 4 is done before it.  If
>the
>cmd size ended on a byte or half word boundary this would mess up the
>crc32
>from what I might expect...In practice it might be that GCC generates
>things
>such that it pads to this anyway).  Adding another symbol is easy, just
>thought I'd point out that it "might" not be strictly equivilent the way
>you
>did it...

Well, on PPC the label is placed after the ALIGN, too (that's where I
stole it ;-).
If you need it for crc check of the ROM image, I don't see any reason
why an additional label couldn't be added before the ALIGN.

We still need '__bss_start' (aligned) in order to clear the BSS
correctly, however.

Cheers
 Anders